Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented May 15, 2025

The change removes an unnecessary division by devicePixelRatio when scaling icons. The division was redundant because:

  1. The image is already being scaled by multiplying with devicePixelRatio in the next line
  2. Keeping both operations would effectively cancel each other out
  3. This simplifies the logic while maintaining the same visual result

The modification ensures cleaner code without changing the actual behavior, as the final scaled image size remains correct.

fix: 移除图标缩放中多余的 devicePixelRatio 除法操作

本次修改移除了图标缩放过程中多余的 devicePixelRatio 除法运算,因为:

  1. 下一行代码已经通过乘以 devicePixelRatio 进行图像缩放
  2. 同时保留两个操作会相互抵消效果
  3. 简化逻辑的同时保持相同的视觉效果

base64的requestedSize是没有被缩放的原始size,不能除缩放

pms: BUG-304699

Summary by Sourcery

Bug Fixes:

  • Remove redundant devicePixelRatio division in icon scaling

The change removes an unnecessary division by devicePixelRatio when
scaling icons. The division was redundant because:
1. The image is already being scaled by multiplying with
devicePixelRatio in the next line
2. Keeping both operations would effectively cancel each other out
3. This simplifies the logic while maintaining the same visual result

The modification ensures cleaner code without changing the actual
behavior, as the final scaled image size remains correct.

fix: 移除图标缩放中多余的 devicePixelRatio 除法操作

本次修改移除了图标缩放过程中多余的 devicePixelRatio 除法运算,因为:
1. 下一行代码已经通过乘以 devicePixelRatio 进行图像缩放
2. 同时保留两个操作会相互抵消效果
3. 简化逻辑的同时保持相同的视觉效果

base64的requestedSize是没有被缩放的原始size,不能除缩放

pms: BUG-304699
@mhduiy mhduiy requested a review from 18202781743 May 15, 2025 06:37
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 移除了对 devicePixelRatio 的处理,可能导致在不同设备上显示的图标大小不一致

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#485
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mhduiy - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented May 15, 2025

Reviewer's Guide

Removed redundant devicePixelRatio division in the icon scaling logic to simplify the implementation while preserving the final image size.

File-Level Changes

Change Details Files
Simplify icon size calculation by removing unnecessary division
  • Deleted the else branch that divided requested icon size by devicePixelRatio
  • Retained direct multiplication of icon_size by devicePixelRatio in the image.scaled call
  • Streamlined conditional logic for clarity
src/private/dquickiconimage.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@mhduiy mhduiy merged commit 3d7c40f into linuxdeepin:master May 15, 2025
17 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request May 15, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants