Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Jun 6, 2025

  1. Changed static width assignment to dynamic binding using Qt.binding
  2. The preview now automatically adjusts when container width changes
  3. Fixes issue where preview wouldn't resize with window
  4. Maintains better visual consistency during runtime adjustments

fix: 修复 QML 预览中的动态宽度绑定问题

  1. 将静态宽度分配改为使用 Qt.binding 的动态绑定
  2. 预览现在会在容器宽度变化时自动调整
  3. 修复了预览不会随窗口调整大小的问题
  4. 在运行时调整时保持更好的视觉一致性

Summary by Sourcery

Use Qt.binding for dynamic width assignment in QML preview to ensure it automatically resizes with its container and maintains visual consistency.

Bug Fixes:

  • Fix preview not resizing when container or window width changes.

Enhancements:

  • Replace static width assignment with Qt.binding dynamic binding for the code preview element.

1. Changed static width assignment to dynamic binding using Qt.binding
2. The preview now automatically adjusts when container width changes
3. Fixes issue where preview wouldn't resize with window
4. Maintains better visual consistency during runtime adjustments

fix: 修复 QML 预览中的动态宽度绑定问题

1. 将静态宽度分配改为使用 Qt.binding 的动态绑定
2. 预览现在会在容器宽度变化时自动调整
3. 修复了预览不会随窗口调整大小的问题
4. 在运行时调整时保持更好的视觉一致性
@18202781743 18202781743 requested review from BLumia and mhduiy June 6, 2025 09:48
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • obj.width = Qt.binding(function () { return codePreview.width })中,使用了Qt.binding来动态绑定codePreview.width,这可能会导致性能问题,因为每次codePreview.width变化时,都会触发重新计算。
  • globalObject.replace(lastPreview, obj)lastPreview = obj这两行代码可能会引起内存泄漏,如果lastPreview对象没有被正确地删除或替换,可能会导致内存无法被回收。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Jun 6, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#489
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 6, 2025

Reviewer's Guide

Replaces the static width assignment in QML preview with a Qt.binding expression so that the preview’s width now dynamically follows container/window size changes, improving visual consistency during runtime adjustments.

File-Level Changes

Change Details Files
Enable dynamic width binding for QML preview
  • Replaced direct obj.width assignment with a Qt.binding expression
  • Bound obj.width to codePreview.width for live updates
examples/exhibition/ViewQMLSource.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@18202781743 18202781743 merged commit 94a0473 into linuxdeepin:master Jun 6, 2025
17 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Jun 6, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants