-
Notifications
You must be signed in to change notification settings - Fork 42
fix: ensure dynamic width binding in QML preview #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Changed static width assignment to dynamic binding using Qt.binding 2. The preview now automatically adjusts when container width changes 3. Fixes issue where preview wouldn't resize with window 4. Maintains better visual consistency during runtime adjustments fix: 修复 QML 预览中的动态宽度绑定问题 1. 将静态宽度分配改为使用 Qt.binding 的动态绑定 2. 预览现在会在容器宽度变化时自动调整 3. 修复了预览不会随窗口调整大小的问题 4. 在运行时调整时保持更好的视觉一致性
deepin pr auto review关键摘要:
是否建议立即修改:
|
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#489
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideReplaces the static width assignment in QML preview with a Qt.binding expression so that the preview’s width now dynamically follows container/window size changes, improving visual consistency during runtime adjustments. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#489
fix: 修复 QML 预览中的动态宽度绑定问题
Summary by Sourcery
Use Qt.binding for dynamic width assignment in QML preview to ensure it automatically resizes with its container and maintains visual consistency.
Bug Fixes:
Enhancements: