-
Notifications
You must be signed in to change notification settings - Fork 42
style: adjust UI color palette values #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#511
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR overhauls the FlowStyle.qml color palette by migrating hardcoded hex values to Qt.rgba for precise transparency, adding missing dark-mode states, aligning crystal theme colors with light/dark requirements, unifying common and crystal definitions, and refining highlight states for better visual feedback. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
- Consider abstracting repeated Qt.rgba color definitions into named constants to reduce duplication and improve maintainability.
- Verify that the adjusted alpha values still meet the required contrast ratios for accessibility in both light and dark modes.
- Ensure the new hoveredDark and pressedDark states are consistently applied across all interactive QML components to avoid missing styling in dark mode.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider abstracting repeated Qt.rgba color definitions into named constants to reduce duplication and improve maintainability.
- Verify that the adjusted alpha values still meet the required contrast ratios for accessibility in both light and dark modes.
- Ensure the new hoveredDark and pressedDark states are consistently applied across all interactive QML components to avoid missing styling in dark mode.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Updated the color palette values in FlowStyle.qml to improve visual consistency and dark mode support. Changes include: 1. Modified background1 colors to use rgba values for better transparency control 2. Added missing hoveredDark and pressedDark states for dark mode 3. Adjusted crystal theme colors to match dark/light mode requirements 4. Unified color handling between common and crystal themes 5. Improved highlight color states for better visual feedback Log: Improved UI color consistency across themes and states Influence: 1. Verify all UI elements render correctly in both light and dark modes 2. Check hover and pressed states for interactive elements 3. Test color transitions between different states 4. Validate accessibility and contrast ratios 5. Ensure consistency across different display configurations style: 调整UI调色板数值 更新了FlowStyle.qml中的调色板数值以提高视觉一致性和暗黑模式支持。修改 包括: 1. 修改background1颜色使用rgba值以获得更好的透明度控制 2. 为暗黑模式添加缺失的hoveredDark和pressedDark状态 3. 调整crystal主题颜色以匹配暗黑/明亮模式需求 4. 统一common和crystal主题的颜色处理 5. 改进高亮颜色状态以获得更好的视觉反馈 Log: 改进了跨主题和状态的UI颜色一致性 Influence: 1. 验证所有UI元素在明亮和暗黑模式下都能正确渲染 2. 检查交互元素的悬停和按下状态 3. 测试不同状态之间的颜色过渡 4. 验证可访问性和对比度比率 5. 确保在不同显示配置下的一致性 PMS: BUG-327451
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#511
deepin pr auto review代码审查意见:
综上所述,代码在颜色值定义、透明度变化、颜色值计算、状态定义顺序和代码格式等方面存在一些潜在的问题,建议进行相应的调整和优化。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 5.7.21 |
|
TAG Bot New tag: 5.7.22 |
Updated the color palette values in FlowStyle.qml to improve visual
consistency and dark mode support. Changes include:
transparency control
Log: Improved UI color consistency across themes and states
Influence:
style: 调整UI调色板数值
更新了FlowStyle.qml中的调色板数值以提高视觉一致性和暗黑模式支持。修改
包括:
Log: 改进了跨主题和状态的UI颜色一致性
Influence:
PMS: BUG-327451
Summary by Sourcery
Revise FlowStyle.qml color palette to improve visual consistency and dark mode support by refining RGBA transparency, adding missing dark states, and unifying theme color definitions
New Features:
Enhancements: