Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Sep 19, 2025

Added missing style properties to AlertToolTip background component
to ensure proper visual appearance. The radius, implicitWidth,
and implicitHeight properties were missing from the FloatingPanel
background, causing inconsistent styling with the design system.
Also added corresponding width, height, and radius properties to
the alertToolTip style definition to provide proper values for these
properties.

The changes ensure that AlertToolTip maintains consistent styling with
the design system specifications and displays correctly with proper
dimensions and rounded corners.

Log: Fixed AlertToolTip background styling to match design
specifications

Influence:

  1. Verify AlertToolTip displays with correct rounded corners
  2. Test that tooltip has proper width and height dimensions
  3. Check that background styling is consistent with other components
  4. Verify tooltip positioning and layout with new size properties
  5. Test on different screen sizes to ensure responsive behavior

fix: 修复AlertToolTip背景样式问题

为AlertToolTip背景组件添加缺失的样式属性以确保正确的视觉外观。
FloatingPanel背景中缺少radius、implicitWidth和implicitHeight属性,导致
与设计系统的样式不一致。同时为alertToolTip样式定义添加了相应的width、
height和radius属性,为这些属性提供正确的值。

这些更改确保AlertToolTip保持与设计系统规范一致的样式,并以正确的尺寸和圆
角显示。

Log: 修复AlertToolTip背景样式以符合设计规范

Influence:

  1. 验证AlertToolTip是否以正确的圆角显示
  2. 测试工具提示是否具有正确的宽度和高度尺寸
  3. 检查背景样式是否与其他组件保持一致
  4. 使用新的尺寸属性验证工具提示的定位和布局
  5. 在不同屏幕尺寸上测试以确保响应式行为

PMS: BUG-334879

Summary by Sourcery

Add missing styling properties to AlertToolTip background and style definitions to ensure consistent dimensions and rounded corners with the design system.

Bug Fixes:

  • Include radius, implicitWidth, and implicitHeight on AlertToolTip's FloatingPanel background.
  • Define width, height, and radius properties for alertToolTip in FlowStyle.qml.

Added missing style properties to AlertToolTip background component
to ensure proper visual appearance. The radius, implicitWidth,
and implicitHeight properties were missing from the FloatingPanel
background, causing inconsistent styling with the design system.
Also added corresponding width, height, and radius properties to
the alertToolTip style definition to provide proper values for these
properties.

The changes ensure that AlertToolTip maintains consistent styling with
the design system specifications and displays correctly with proper
dimensions and rounded corners.

Log: Fixed AlertToolTip background styling to match design
specifications

Influence:
1. Verify AlertToolTip displays with correct rounded corners
2. Test that tooltip has proper width and height dimensions
3. Check that background styling is consistent with other components
4. Verify tooltip positioning and layout with new size properties
5. Test on different screen sizes to ensure responsive behavior

fix: 修复AlertToolTip背景样式问题

为AlertToolTip背景组件添加缺失的样式属性以确保正确的视觉外观。
FloatingPanel背景中缺少radius、implicitWidth和implicitHeight属性,导致
与设计系统的样式不一致。同时为alertToolTip样式定义添加了相应的width、
height和radius属性,为这些属性提供正确的值。

这些更改确保AlertToolTip保持与设计系统规范一致的样式,并以正确的尺寸和圆
角显示。

Log: 修复AlertToolTip背景样式以符合设计规范

Influence:
1. 验证AlertToolTip是否以正确的圆角显示
2. 测试工具提示是否具有正确的宽度和高度尺寸
3. 检查背景样式是否与其他组件保持一致
4. 使用新的尺寸属性验证工具提示的定位和布局
5. 在不同屏幕尺寸上测试以确保响应式行为

PMS: BUG-334879
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 19, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#528
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR extends the AlertToolTip component’s QML definitions by inserting missing size and radius properties into the FloatingPanel background and its style object, ensuring the tooltip’s dimensions and rounded corners adhere to the design system.

File-Level Changes

Change Details Files
Add radius and size hints to the FloatingPanel background in AlertToolTip.qml
  • Insert radius binding to DS.Style.alertToolTip.radius
  • Insert implicitWidth binding to DS.Style.alertToolTip.width
  • Insert implicitHeight binding to DS.Style.alertToolTip.height
qt6/src/qml/AlertToolTip.qml
Define width, height, and radius in FlowStyle’s alertToolTip style
  • Add width property with value 30
  • Add height property with value 24
  • Add radius property with value 6
qt6/src/qml/FlowStyle.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 9d2ee1c into linuxdeepin:master Sep 19, 2025
20 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6declarative that referenced this pull request Sep 19, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants