-
Notifications
You must be signed in to change notification settings - Fork 42
fix: fix AlertToolTip background styling #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added missing style properties to AlertToolTip background component to ensure proper visual appearance. The radius, implicitWidth, and implicitHeight properties were missing from the FloatingPanel background, causing inconsistent styling with the design system. Also added corresponding width, height, and radius properties to the alertToolTip style definition to provide proper values for these properties. The changes ensure that AlertToolTip maintains consistent styling with the design system specifications and displays correctly with proper dimensions and rounded corners. Log: Fixed AlertToolTip background styling to match design specifications Influence: 1. Verify AlertToolTip displays with correct rounded corners 2. Test that tooltip has proper width and height dimensions 3. Check that background styling is consistent with other components 4. Verify tooltip positioning and layout with new size properties 5. Test on different screen sizes to ensure responsive behavior fix: 修复AlertToolTip背景样式问题 为AlertToolTip背景组件添加缺失的样式属性以确保正确的视觉外观。 FloatingPanel背景中缺少radius、implicitWidth和implicitHeight属性,导致 与设计系统的样式不一致。同时为alertToolTip样式定义添加了相应的width、 height和radius属性,为这些属性提供正确的值。 这些更改确保AlertToolTip保持与设计系统规范一致的样式,并以正确的尺寸和圆 角显示。 Log: 修复AlertToolTip背景样式以符合设计规范 Influence: 1. 验证AlertToolTip是否以正确的圆角显示 2. 测试工具提示是否具有正确的宽度和高度尺寸 3. 检查背景样式是否与其他组件保持一致 4. 使用新的尺寸属性验证工具提示的定位和布局 5. 在不同屏幕尺寸上测试以确保响应式行为 PMS: BUG-334879
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#528
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR extends the AlertToolTip component’s QML definitions by inserting missing size and radius properties into the FloatingPanel background and its style object, ensuring the tooltip’s dimensions and rounded corners adhere to the design system. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#528
Added missing style properties to AlertToolTip background component
to ensure proper visual appearance. The radius, implicitWidth,
and implicitHeight properties were missing from the FloatingPanel
background, causing inconsistent styling with the design system.
Also added corresponding width, height, and radius properties to
the alertToolTip style definition to provide proper values for these
properties.
The changes ensure that AlertToolTip maintains consistent styling with
the design system specifications and displays correctly with proper
dimensions and rounded corners.
Log: Fixed AlertToolTip background styling to match design
specifications
Influence:
fix: 修复AlertToolTip背景样式问题
为AlertToolTip背景组件添加缺失的样式属性以确保正确的视觉外观。
FloatingPanel背景中缺少radius、implicitWidth和implicitHeight属性,导致
与设计系统的样式不一致。同时为alertToolTip样式定义添加了相应的width、
height和radius属性,为这些属性提供正确的值。
这些更改确保AlertToolTip保持与设计系统规范一致的样式,并以正确的尺寸和圆
角显示。
Log: 修复AlertToolTip背景样式以符合设计规范
Influence:
PMS: BUG-334879
Summary by Sourcery
Add missing styling properties to AlertToolTip background and style definitions to ensure consistent dimensions and rounded corners with the design system.
Bug Fixes: