-
Notifications
You must be signed in to change notification settings - Fork 53
fix: FTBFS with Qt 6.9.2 #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
确保 Qt 6.9.2 可构建. 相关 Qt 变动: qt/qtbase@a676ac0 Log:
deepin-ci-robot
added a commit
to linuxdeepin/qt6integration
that referenced
this pull request
Aug 28, 2025
Synchronize source files from linuxdeepin/qt5integration. Source-pull-request: linuxdeepin/qt5integration#280
Contributor
deepin pr auto review这段代码审查如下:
改进建议: static void updateWindowGeometry(QWindow *w)
{
if (!w || !w->handle()) {
return;
}
if (w->property(DNOT_UPDATE_WINDOW_GEOMETRY).toBool()) {
const QRect nativeGeometry = w->handle()->geometry();
#if QT_VERSION >= QT_VERSION_CHECK(6, 9, 2)
QWindowSystemInterfacePrivate::GeometryChangeEvent gce(w,
QHighDpi::fromNativeWindowGeometry(nativeGeometry, w),
QHighDpi::fromNativePixels(nativeGeometry, w)
#else
QWindowSystemInterfacePrivate::GeometryChangeEvent gce(w,
QHighDpi::fromNativePixels(nativeGeometry, w)
#endif
#if QT_VERSION < QT_VERSION_CHECK(5, 10, 0)
, QRect()
#endif
);
}
}
}改进后的代码:
这些改进可以提高代码的安全性、性能和可维护性,同时保持了原有的功能不变。 |
BLumia
added a commit
to BLumia/qt5platform-plugins
that referenced
this pull request
Aug 28, 2025
Related: linuxdeepin/qt5integration#280 Log:
BLumia
added a commit
to BLumia/qt5platform-plugins
that referenced
this pull request
Aug 28, 2025
Related: linuxdeepin/qt5integration#280 Log:
18202781743
approved these changes
Aug 29, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
BLumia
added a commit
to linuxdeepin/qt5platform-plugins
that referenced
this pull request
Aug 29, 2025
Related: linuxdeepin/qt5integration#280 Log:
BLumia
pushed a commit
to linuxdeepin/qt6integration
that referenced
this pull request
Aug 29, 2025
Synchronize source files from linuxdeepin/qt5integration. Source-pull-request: linuxdeepin/qt5integration#280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
确保 Qt 6.9.2 可构建. 相关 Qt 变动:
qt/qtbase@a676ac0