fix: fix wrong display render issue when switching VT too quickly

[calsys456]

When cooperating with DDM, switching VT will not drop DRM FD. This makes treeland still able to draw to the DRM after VT switch, which will cause wrong display rendering when switching VT too quickly. This commit cooperate new treeland-ddm-v1 protocol and expose interface to enable / disable global rendering, which is used in DDM to control render before / after TTY switching, to solve the render issue.

Summary by Sourcery

Add global rendering control to fix display glitches during rapid VT switches by pausing and resuming output rendering via the treeland-ddm-v1 protocol.

New Features:

• Expose enable_render and disable_render methods in the treeland_ddm v1 interface for DDM to control global rendering.
• Implement enableRender and disableRender in Helper to toggle rendering on the output window.
• Add setRenderEnabled API and renderEnabled guard in WOutputRenderWindow to pause and resume rendering.

Bug Fixes:

• Prevent wrong display rendering when switching virtual terminals too quickly by disabling rendering during the switch.

Enhancements:

• Update the treeland-ddm interface and cooperate with the new treeland-ddm-v1 protocol.

[deepin-ci-robot]

Hi @apr3vau. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sourcery-ai]

Reviewer's Guide

Implements new treeland-ddm-v1 interface methods to enable/disable global rendering, adds a renderEnabled flag in the QtQuick render window that gates the doRender process, and exposes corresponding Helper layer methods; this enables DDM to suspend/resume rendering around VT switches and resolves incorrect display outputs when switching too quickly.

Sequence diagram for enabling/disabling global rendering via DDM interface

sequenceDiagram
    participant DDM
    participant treeland_ddm_interface
    participant Helper
    participant WOutputRenderWindow
    DDM->>treeland_ddm_interface: enable_render/disable_render
    treeland_ddm_interface->>Helper: enableRender()/disableRender()
    Helper->>WOutputRenderWindow: setRenderEnabled(true/false)
    WOutputRenderWindow->>WOutputRenderWindow: doRender() (gated by renderEnabled)

Loading

Entity relationship diagram for DDM interface and Helper integration

erDiagram
    TREELAND_DDM_INTERFACE {
        switch_to_greeter
        switch_to_user
        activate_session
        deactivate_session
        enable_render
        disable_render
    }
    HELPER {
        enableRender
        disableRender
    }
    TREELAND_DDM_INTERFACE ||--o| HELPER: calls

Loading

Class diagram for updated Helper and WOutputRenderWindow classes

classDiagram
    class Helper {
        +activateSession()
        +deactivateSession()
        +enableRender()
        +disableRender()
        -m_renderWindow: WOutputRenderWindow*
    }
    class WOutputRenderWindow {
        +setRenderEnabled(bool enabled)
        +inRendering() const
        -renderEnabled: bool
        +doRender(...)
    }
    Helper --> WOutputRenderWindow: uses

Loading

File-Level Changes

Change	Details	Files
Extend DDM protocol with enable/disable rendering hooks	Added enableRender/disableRender handlers in ddminterfacev1.cpp Updated treeland_ddm_impl struct to include new methods	src/modules/ddm/ddminterfacev1.cpp
Introduce renderEnabled flag to gate render loop	Added renderEnabled member and early-return check in doRender Implemented setRenderEnabled setter in WOutputRenderWindow	waylib/src/server/qtquick/woutputrenderwindow.cpp waylib/src/server/qtquick/woutputrenderwindow.h
Expose Helper layer methods to toggle rendering	Declared enableRender/disableRender in Helper class header Implemented Helper::enableRender() and disableRender() to call setRenderEnabled	src/seat/helper.cpp src/seat/helper.h

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[calsys456]

Other two PR link: linuxdeepin/ddm#35 linuxdeepin/treeland-protocols#21

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apr3vau, zccrs

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment