Fix for #24 #29
Merged
Fix for #24 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuxdeploy-plugin-gtk.sh
Outdated
| while IFS= read -r -d '' file; do | ||
| # shellcheck disable=SC2016 | ||
| patchelf --set-rpath '$ORIGIN/../../../..' "$APPDIR/$file" | ||
| patchelf --set-rpath '$ORIGIN' "$APPDIR/$file" |
There was a problem hiding this comment.
Not sure if still required. linuxdeploy.AppImage already to this automatically if I am correct.
There was a problem hiding this comment.
I think the main issue with this line is that it forcefully overwrites the existing rpath. I think linuxdeploy now just appends to the rpath, in case it exists.
There was a problem hiding this comment.
Ok, I removed patchelf dependency in 07ebdec.
It seems it was removed in 3c78e96 for no reason
|
I am able to run CPU-X without warnings now. |
TheAssassin
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
Great to get rid of patchelf as a dependency, as well as getting rid of the tempdir. Thanks a ton @x0rg.
|
CC #21: patchelf is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix for #24 is to avoid to use a temporary directory for
immodules.cacheandloaders.cachefiles.Please try and comment.