housekeeping: fix list iteration and memleak in ldsm-dialog #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if this dialog is likely never shown, fix the list iteration and memory leak when handling the ignore-paths setting. This will address the (justified) gcc warning regarding the wrong use of G_N_ELEMENTS on the strv.
Contributor
Author
|
This entire dialogue is a full-blown fallback in case libnotify doesn't report support for notification actions. In my opinion, we could drop it entirely and accept that there might be no support for actions for whatever reason. |
Member
|
Agreed, let's just remove it. Only Cinnamon uses this, and Cinnamon supports actions. |
Contributor
Author
Created #433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if this dialog is likely never shown, fix the list iteration and
memory leak when handling the ignore-paths setting.
This will address the (justified) gcc warning regarding the wrong use
of G_N_ELEMENTS on the strv.