Add currency query param to all endpoints#34
Closed
thomascullen wants to merge 1 commit intolionsharecapital:masterfrom
Closed
Add currency query param to all endpoints#34thomascullen wants to merge 1 commit intolionsharecapital:masterfrom
thomascullen wants to merge 1 commit intolionsharecapital:masterfrom
Conversation
Contributor
|
@thomascullen hey. Other things pretty much took our focus for a long time and nobody has been following this repo. your PR looks good and we would love to integrate it. Looks like it's a bit out of date now but we're happy to re-do it once we have time (need a weekend) or if you want to rebase it. I think it would make many people happy as adding it to the application wouldn't be hard |
|
Would love to get this in—will try to look at it over the next week or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all 👋, big fan of the Lionshare project! As i'm based in Europe I would love to have the ability to get results in EUR rather than USD. I have made a first pass at adding this functionality to the API by using the http://fixer.io/ API.
I have set the currency rates to be updated inside the UpdateJob class however it may be best reduce the frequency of this call.