Skip to content

Conversation

@javepaid
Copy link
Member

@javepaid javepaid commented Dec 4, 2024

Ticket: https://lipsumtext.atlassian.net/browse/LS-24

Also added feature wherein states are reset once UTC day changes

@javepaid javepaid requested a review from silikeite as a code owner December 4, 2024 22:47
@javepaid
Copy link
Member Author

javepaid commented Dec 4, 2024

Bugs have been discovered within code; will set PR to draft for now

@javepaid javepaid marked this pull request as draft December 4, 2024 22:59
@silikeite
Copy link
Member

Please disable the now-no-longer-relevant tests first.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying weldor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c4b25d
Status: ✅  Deploy successful!
Preview URL: https://578b8b37.weldor.pages.dev
Branch Preview URL: https://24-local-storage.weldor.pages.dev

View logs

@javepaid javepaid marked this pull request as ready for review December 5, 2024 10:35
@javepaid javepaid marked this pull request as draft December 7, 2024 12:04
@javepaid javepaid marked this pull request as ready for review December 7, 2024 15:08
@lipsumtext lipsumtext locked and limited conversation to collaborators Dec 8, 2024
@lipsumtext lipsumtext unlocked this conversation Dec 8, 2024
Copy link
Member

@silikeite silikeite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests now passing. Merging.

@silikeite silikeite merged commit fa9eeb1 into main Dec 8, 2024
2 checks passed
@silikeite silikeite deleted the 24_local_storage branch December 8, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants