chore(automerge): remove check_suite if-condition on automerge job#26
Merged
chore(automerge): remove check_suite if-condition on automerge job#26
Conversation
Review Summary by QodoRemove check_suite if-condition from automerge workflow
WalkthroughsDescription• Removes obsolete check_suite event condition from automerge job • Simplifies workflow by eliminating workaround for legacy GitHub Actions behavior • Job now runs unconditionally on all configured trigger events Diagramflowchart LR
A["automerge job"] -->|"removes conditional logic"| B["Runs on all trigger events"]
C["check_suite event"] -->|"no longer filtered"| B
File Changes1. .github/workflows/automerge.yml
|
Code Review by Qodo
1. Unfiltered check_suite runs
|
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 5 5
Lines 431 431
Branches 88 88
=======================================
Hits 404 404
Misses 22 22
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
if:block on theautomergejob that conditioned oncheck_suiteevents. The condition was a workaround for an older github-actions behavior and is no longer necessary — the workflow now runs unconditionally on its triggering events.jobs: automerge: runs-on: ubuntu-latest - if: > - github.event_name != 'check_suite' || - github.event.check_suite.pull_requests[0] != null permissions: contents: write pull-requests: write