Add enableAuthProxyCompat to recover SW from auth proxy expiry#2190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Feature
Overview
Adds a new config option,
appConfig.enableAuthProxyCompat.When this is enabled, along with
enableServiceWorkerand when Dashy is served behind an auth proxy, then the SW will attempt to fetch from an auth-enabled endpoint (getUser) with cache disabled. If this fails with an auth error, then we unregister the service worker and trigger a redirect (which will send user to login page to reauthenticate). There's a session storage key to prevent redirect loop.Issue Number
Fixes #2189