Skip to content

Add yarn build to pipeline to ensure it will be possible to build post merge #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add yarn build to pipeline to ensure it will be possible to build post merge #233

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d248e8
Add yarn build to pipeline to ensure it will be possible to build pos…
markdavison Apr 26, 2022
25255a7
Add missing on step to workflow
markdavison Apr 26, 2022
e7022eb
Run test on opening a PR to any branch
markdavison Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
name: CI

on:
push:
branches: [main]

jobs:
build:
test:
on: [pull_request]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -14,10 +12,14 @@ jobs:
node-version: '14'
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn build
- run: yarn test

deploy:
needs: build
on:
push:
Copy link
Contributor

@bdmason bdmason May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add workflow_dispatch here we can trigger deploys from github manually. If the AWS work will mean this becomes redundant then just ignore this comment.

branches: [main]
needs: test
runs-on: ubuntu-latest
environment: production
steps:
Expand Down