fix(conversation): cover validation retries and stale mute state - #8
Open
jakepu wants to merge 1 commit into
Open
fix(conversation): cover validation retries and stale mute state#8jakepu wants to merge 1 commit into
jakepu wants to merge 1 commit into
Conversation
13 tasks
liuhao1024
pushed a commit
that referenced
this pull request
Aug 15, 2026
…eview #8) test_progress_extends_idle_budget_until_success raced wall-clock: the 0.1s-idle/0.04s-tick shape left ~60ms of slack per tick, so one slow scheduler pass on a loaded CI box lapsed the idle budget mid-loop. Widened to 0.5s idle / 0.1s ticks (5x per-tick margin, total runtime still <1s) per the FLAKY policy's minimum-margin guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a focused follow-up to NousResearch/hermes-agent#63888. It keeps that PR's original fix and regression test, while closing three adjacent state-machine gaps found during review.
Changes
continue._mute_post_responsetogether with the cached fallback fields when substantive work resumes.Why
On the current NousResearch#63888 head, the expanded suite produced:
Malformed JSON and unknown-tool retries could bypass classification and still finalize two-turn-old housekeeping narration. A normal substantive turn also left
_mute_post_response=True, suppressing progress output.With this patch, all seven focused tests—including NousResearch#63888's original standalone regression—pass.
Verification
This PR targets the existing contributor branch so the improvements can be incorporated into NousResearch#63888 without opening a competing upstream PR.