Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a transcoding bug that occurred when remote transcoder was removed #2746

Closed

Conversation

eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Feb 7, 2023

What does this pull request do? Explain your changes. (required)
This change fixes a bug that caused an orchestrator to lose all transcoders when one of it's transcoders disconnects unexpectedly.

Specific updates (required)

  • Simplified logic in removeFromRemoteTranscoders so that correct transcoder is removed from RemoteTranscoderManager

How did you test each of these updates (required)
We tested up to 4 streams going to an orchestrator with up to 4 remote transcoders. We stopped one of the transcoders in the following scenarios and observed streams move to another transcoder without disconnecting any other transcoders.

  • 1 stream on each of the 4 remote transcoders
  • 2 streams on each of 2 remote transcoders
  • 4 streams on 1 transcoder with 3 additional transcoders having 0 load.

In every case we observed the streams safely move to another available transcoder without causing other transcoders to break.

Does this pull request close any open issues?

#2605
#2706

Checklist:

@eliteprox eliteprox marked this pull request as ready for review February 7, 2023 06:00
@eliteprox eliteprox changed the title Fixed a transcoding bug that occured when remote transcoder was removed Fixed a transcoding bug that occurred when remote transcoder was removed Feb 7, 2023
@eliteprox eliteprox closed this Feb 7, 2023
@eliteprox eliteprox deleted the develop-fixtranscoderdrop-recent branch February 7, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant