feat(client, overlay): Optimize frame processing during manual loading states #77
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g states - Updated TrickleClient to utilize this method, allowing immediate overlay frame generation without blocking the processor. - Introduced `set_loading_overlay` method in StreamProcessor to enable or disable the loading overlay for the current client, enhancing user experience during loading scenarios.
- Added a check in OverlayController to return false for overlay generation when passthrough mode is active, ensuring proper handling of manual loading states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
set_loading_overlayto the StreamProcessor to support toggling overlay without blocking the frame processor. This is an alternative to returningVideoProcessingResult.WITHHELDwhich involves blocking client frame processing.set_loading_overlaymethod in StreamProcessor to enable or disable the loading overlay for the current client, enhancing user experience during loading scenarios.