Skip to content

feat: remove need for CA bundle initContainer #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: remove need for CA bundle initContainer #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions config/samples/example-with-ca-bundle.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ spec:
value: "meta-llama/Llama-3.2-1B-Instruct"
- name: VLLM_URL
value: "https://vllm-server.vllm-dist.svc.cluster.local:8000/v1"
- name: VLLM_TLS_VERIFY
value: "/etc/ssl/certs/ca-bundle.crt"
userConfig:
configMapName: llama-stack-config
# configMapNamespace: "" # Optional - defaults to the same namespace as the CR
Expand Down
12 changes: 4 additions & 8 deletions controllers/llamastackdistribution_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,10 @@ const (
manifestsBasePath = "manifests/base"

// CA Bundle related constants.
DefaultCABundleKey = "ca-bundle.crt"
CABundleMountPath = "/etc/ssl/certs/ca-bundle.crt"
CABundleTempPath = "/tmp/ca-bundle/ca-bundle.crt"
CABundleVolumeName = "ca-bundle"
CABundleSourceDir = "/tmp/ca-source"
CABundleInitName = "ca-bundle-init"
CABundleSourceVolName = "ca-bundle-source"
CABundleTempDir = "/tmp/ca-bundle"
DefaultCABundleKey = "ca-bundle.crt"
CABundleVolumeName = "ca-bundle"
CABundleSourceMountDir = "/etc/ssl/certs/ca-certificates" // Where ConfigMap keys are mounted
CABundleProcessedDir = "/tmp/ca-bundle-processed" // Where processed certs go after c_rehash

// ODH/RHOAI well-known ConfigMap for trusted CA bundles.
odhTrustedCABundleConfigMap = "odh-trusted-ca-bundle"
Expand Down
Loading