fix(openai_responses): OpenAIResponsesObject is not complete #3194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @iamemilio! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
iamemilio
force-pushed
the
responses_object
branch
from
966588c to
12f55c6
Compare
meta-cla
bot
added
the
CLA Signed
iamemilio
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
cdoern
reviewed
Aug 19, 2025
|
|
||
| created_at: int | ||
| error: OpenAIResponseError | None = None | ||
| error: Optional[OpenAIResponseError] = None |
Contributor
There was a problem hiding this comment.
I think mypy will yell at you for this and ask you to do | None
| """ | ||
|
|
||
|
|
||
| class ToolChoiceAllowed(BaseModel): |
Contributor
There was a problem hiding this comment.
I think if these are nested you might need to add json_schema
Contributor
There was a problem hiding this comment.
if you run pre-commit run --all-files the openapi spec will try to regen. Might need to pip install pre-commit if you haven't
| format: OpenAIResponseTextFormat | None = None | ||
| # Default to text format to avoid breaking the loading of old responses | ||
| # before the field was added. New responses will have this set always. | ||
| format: OpenAIResponseTextFormat | None = Field(default_factory=lambda: OpenAIResponseTextFormat(type="text")) |
Contributor
There was a problem hiding this comment.
this makes sense to me I think
Contributor
Author
|
Thanks, I'll patch this! |
iamemilio
force-pushed
the
responses_object
branch
from
307dd92 to
0e59d96
Compare
iamemilio
force-pushed
the
responses_object
branch
from
0e59d96 to
8fb17ba
Compare
Contributor
|
Pre-commit seems to be still failing? |
Contributor
Author
|
I think I found a good resolution for this. I enhanced the openapi generation to allow Literals with multiple fields. I also realize that these fields are not available in the |
iamemilio
force-pushed
the
responses_object
branch
2 times, most recently
from
e871e57 to
82a9099
Compare
…ion and discrimintated unions
iamemilio
force-pushed
the
responses_object
branch
from
82a9099 to
80b82c0
Compare
Contributor
Author
|
updated with merge commit, hopefully the protobuff bug in the vec-io test has been patched |
ashwinb
requested changes
Aug 25, 2025
Contributor
ashwinb
left a comment
ashwinb
left a comment
There was a problem hiding this comment.
What is the test plan for this?
Contributor
Author
|
Thanks for the review, I am still very new to this code base so its helpful to get some expert guidance! I added some unit tests just to make sure this change doesn't come with any unintended consequences. I want to clarify that these changes only impact the Do you think these tests are appropriate enough, or would you recommend additional testing for this PR? Also, is there additional testing that needs to be done to support the stainless clients? |
iamemilio
force-pushed
the
responses_object
branch
from
3880626 to
66806c4
Compare
Contributor
|
@iamemilio , can you please rebase and re-push so the |
cdoern
approved these changes
Sep 17, 2025
Contributor
Author
|
@ashwinb could you take one more look at this |
Contributor
|
running an oasdiff against the openAI API: there are a few "breakages" but they might be misnomers, please take a look ! @iamemilio |
Contributor
|
I could be using a different version of the spec, or the tool could be too picky on what is "broken" but I figured I'd share just in case ^ |
Contributor
Author
|
Seems like at least some of these are a me problem. Let me see if there is a better way to address this. Where are you getting the latest openapi spec for openai? |
Contributor
Collaborator
|
Was Ashwin's comment and request about a test plan addressed yet? Were you able to run Llama Stack with these changes against a common provider, such as vLLM, and ensure the integration tests all pass (or at least no new ones fail...) from before/after this change? |
Contributor
Author
|
It seems a major refactor is in order in the openapi spec, this PR will need to be re-written. Then I will address the review concerns. |
Contributor
Author
|
Hi all, I am going to close this and re-address this using the smaller issues filed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gaps in Responses Response Object
Fixes #3040
Note: this is hand written and will need to be maintained, a long term strategy to stay in sync with OpenAI is needed.