- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.2k
 
fix: clear model cache when run.yaml model list changes #3198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f32e42a    to
    91cf6a7      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do "store + cleanup" instead let's just not store things we don't want to be stored persistently. It seems like what we want to say generically is that there are three ways of registering models:
- user provided (via the register API)
 - admin provided (via run.yaml)
 - provider provided (listed via the provider)
 
We need to only store the first parts and the rest are dynamically refreshed / loaded on every single startup of the server.
| 
           @Ygnas are you still working on this one?  | 
    
12d9a08    to
    db63f94      
    Compare
  
    
What does this PR do?
closes: #3150
Fixes the model cache not clearing when run.yaml model list changes by implementing proper cleanup mechanisms and adds unit tests.
Not sure exactly what is with all those models as
listed_from_provider. At the moment they are still there.Test Plan
Adding 2 models with:
And
run.yamlReturned models looks like:
After server restart and model removed from
run.yamlonly the manually added one remains: