-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Fix mock vector DB schema in Qdrant tests #3295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
leseb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattf is this fixing your issue?
franciscojavierarceo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varshaprasad96 can you add a test that reproduces @mattf's issue?
While I'm sure this does solve his issue, generally when an unexpected bug comes up I always introduce a new test to ensure it doesn't happen again. :D
|
frankly, idk. i reset my environment to make this go away so i could proceed on something else. i /think/ the solution was to remove the kvstore from .llama/runtime/, which is concerning because the unit tests should be entirely isolated. |
|
@franciscojavierarceo This was a one off issue that I was able to reproduce as I had an older LLS version (~2.16) running around, with qdrant running remotely on older schema that we had defined. I am not able reproduce this in main when I start from a clean state (as Matt mentioned deleting kvstore is all that's needed). This change however is good to have to ensure we have mock DB's schema defined as we want. I'm not sure if there is a better way to add a test for this scenario. |
|
Okay, not an awesome experience but I'm okay with moving on. if this comes up again we'll need to make sure we get to a root cause. |
What does this PR do?
Fix: #3293
Test Plan