Skip to content

Conversation

@varshaprasad96
Copy link
Contributor

What does this PR do?

Fix: #3293

Test Plan

===================================================== test session starts =====================================================
platform darwin -- Python 3.12.11, pytest-7.4.4, pluggy-1.5.0 -- /Users/vnarsing/miniconda3/envs/stack-client/bin/python
cachedir: .pytest_cache
metadata: {'Python': '3.12.11', 'Platform': 'macOS-14.7.7-arm64-arm-64bit', 'Packages': {'pytest': '7.4.4', 'pluggy': '1.5.0'}, 'Plugins': {'asyncio': '0.23.8', 'cov': '6.0.0', 'timeout': '2.2.0', 'socket': '0.7.0', 'xdist': '3.8.0', 'html': '3.1.1', 'langsmith': '0.3.39', 'anyio': '4.8.0', 'metadata': '3.0.0'}}
rootdir: /Users/vnarsing/go/src/github/meta-llama/llama-stack
configfile: pyproject.toml
plugins: asyncio-0.23.8, cov-6.0.0, timeout-2.2.0, socket-0.7.0, xdist-3.8.0, html-3.1.1, langsmith-0.3.39, anyio-4.8.0, metadata-3.0.0
asyncio: mode=Mode.AUTO
collected 3 items                                                                                                             

tests/unit/providers/vector_io/test_qdrant.py::test_qdrant_adapter_returns_expected_chunks[2-2] PASSED                  [ 33%]
tests/unit/providers/vector_io/test_qdrant.py::test_qdrant_adapter_returns_expected_chunks[100-60] PASSED               [ 66%]
tests/unit/providers/vector_io/test_qdrant.py::test_qdrant_register_and_unregister_vector_db PASSED                     [100%]

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 1, 2025
@varshaprasad96 varshaprasad96 changed the title [fix] Fix mock vector DB schema in Qdrant tests fix: Fix mock vector DB schema in Qdrant tests Sep 1, 2025
Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattf is this fixing your issue?

Copy link
Collaborator

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshaprasad96 can you add a test that reproduces @mattf's issue?

While I'm sure this does solve his issue, generally when an unexpected bug comes up I always introduce a new test to ensure it doesn't happen again. :D

@mattf
Copy link
Collaborator

mattf commented Sep 2, 2025

frankly, idk. i reset my environment to make this go away so i could proceed on something else.

i /think/ the solution was to remove the kvstore from .llama/runtime/, which is concerning because the unit tests should be entirely isolated.

@varshaprasad96
Copy link
Contributor Author

varshaprasad96 commented Sep 2, 2025

@franciscojavierarceo This was a one off issue that I was able to reproduce as I had an older LLS version (~2.16) running around, with qdrant running remotely on older schema that we had defined. I am not able reproduce this in main when I start from a clean state (as Matt mentioned deleting kvstore is all that's needed). This change however is good to have to ensure we have mock DB's schema defined as we want. I'm not sure if there is a better way to add a test for this scenario.

@franciscojavierarceo
Copy link
Collaborator

Okay, not an awesome experience but I'm okay with moving on. if this comes up again we'll need to make sure we get to a root cause.

@leseb leseb merged commit c59d8c5 into llamastack:main Sep 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

./scripts/unit-tests.sh failing on test_qdrant.py

4 participants