chore(apis): unpublish deprecated /v1/inference apis #3297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recated inference to openai-compat
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@raghotham @ashwinb this can go into the 0.3 release and the impls can be removed later |
mattf
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
ehhuang
reviewed
Sep 26, 2025
| @@ -1,187 +0,0 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
Collaborator
Author
There was a problem hiding this comment.
it was only testing with the removed api
Contributor
There was a problem hiding this comment.
@mattf but then would the tests be meaningful if you converted the calls to the openai equivalents?
ashwinb
reviewed
Sep 26, 2025
| @@ -1,545 +0,0 @@ | |||
| # Copyright (c) Meta Platforms, Inc. and affiliates. | |||
Contributor
There was a problem hiding this comment.
we had a bunch of tests here. just quickly checking if we have coverage for the openai endpoints in place?
Collaborator
Author
There was a problem hiding this comment.
ported most of these over. skipped the llama-4 one.
ashwinb
approved these changes
Sep 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
unpublish (make unavailable to users) the following apis -
/v1/inference/completion, replaced by/v1/openai/v1/completions/v1/inference/chat-completion, replaced by/v1/openai/v1/chat/completions/v1/inference/embeddings, replaced by/v1/openai/v1/embeddings/v1/inference/batch-completion, replaced by/v1/openai/v1/batches/v1/inference/batch-chat-completion, replaced by/v1/openai/v1/batchesnote: the implementations are still available for internal use, e.g. agents uses chat-completion.