Skip to content

Conversation

skamenan7
Copy link
Contributor

What does this PR do?

Improved bedrock provider config to read from environment variables like AWS_ACCESS_KEY_ID. Updated all
fields to use default_factory with lambda patterns like the nvidia provider does.

Now the environment variables work as documented.

Closes #3305

Test Plan

Ran the new bedrock config tests:

python -m pytest tests/unit/providers/inference/bedrock/test_config.py -v

Verified existing provider tests still work:
python -m pytest tests/unit/providers/test_configs.py -v

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 2, 2025
@skamenan7 skamenan7 force-pushed the fix/bedrock-lambda-config-3305 branch 2 times, most recently from f5fa145 to 2a341b4 Compare September 3, 2025 14:09
Also added tests to make sure the env var handling works correctly.

Fixes llamastack#3305
@leseb leseb merged commit 0b00c68 into llamastack:main Sep 5, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read config values in bedrock provider as lambdas
2 participants