feat: Add langchain llamastack Integration example notebook #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slekkala1
requested review from
ashwinb,
yanxi0830,
hardikjshah,
raghotham,
ehhuang,
terrytangyuan,
leseb,
bbrowning,
reluctantfuturist and
mattf
as code owners
meta-cla
bot
added
the
CLA Signed
ehhuang
reviewed
Sep 3, 2025
| } | ||
| ], | ||
| "source": [ | ||
| "!pip install fastapi uvicorn \"langchain>=0.2\" langchain-openai \\\n", |
| "source": [ | ||
| "# Insert chunks into FAISS vector store\n", | ||
| "\n", | ||
| "response = client.vector_io.insert(vector_db_id=\"acme_docs\", chunks=chunks)" |
There was a problem hiding this comment.
yea let's use the new vector_stores APIs instead
mattf
reviewed
Sep 3, 2025
There was a problem hiding this comment.
ways to make this simpler -
!pip installeverything in one step- use
pkill -f llama_stack.core.server.server -e - use
uv run --with llama-stack llama stack build ... --runfor one step install & startup - avoid
!pip installandsubprocess(... "pip"...) - the vector_store api will do this chunking for you
- pass
base_urlandapi_keytoChatOpenAIinstead of seting env vars
questions -
- why do you need to adjust
UV_SYSTEM_PYTHON? - why are so many models listed?
slekkala1
force-pushed
the
add-langchain-llamastack-nb
branch
from
0019616 to
7ae7d6a
Compare
For this, I have added a comment above, just in case user has this set
Removed the long list and made it short just of the provider used in the tutorials @mattf thanks for the helpful comments! I have made it simpler with the suggestions above. |
|
@mattf Will be landing this, if no other comments to address? |
ok landing for now, feel free to raise a task if anything pending still |
iamemilio
pushed a commit
to iamemilio/llama-stack
that referenced
this pull request
Sep 24, 2025
…ck#3314) # What does this PR do? The notebook was reverted(llamastack#3259) as it had some local paths, I missed correcting. Trying with corrections now ## Test Plan Ran the Jupyter notebook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The notebook was reverted(#3259) as it had some local paths, I missed correcting. Trying with corrections now
Test Plan
Ran the Jupyter notebook