chore(recorder): update mocks to be closer to non-mock environment #3442
Conversation
the @required_args decorator in openai-python is masking the async nature
of the {AsyncCompletions,chat.AsyncCompletions}.create method.
see openai/openai-python#996
this means two things -
0. we cannot use iscoroutine in the recorder to detect async vs non
1. our mocks are inappropriately introducing identifiable async
for (0), we update the iscoroutine check w/ detection of /v1/models,
which is the only non-async function we mock & record.
for (1), we could leave everything as is and assume (0) will catch errors.
to be defensive, we update the unit tests to mock below create methods,
allowing the true openai-python create() methods to be tested.
mattf
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
|
@raghotham i found a bug in #3426. our mocks were masking a bug in openai-python. |
|
With this PR I'm still having problems using models.list with the vllm provider, see logs The only thing I've managed to get consistently working is Special handling for models.list (AsyncIterableModelsWrapper in #3128) which supports both Direct iteration and await then iterate |
ok, once this is in i'll check on that. |
…lamastack#3442) # What does this PR do? the @required_args decorator in openai-python is masking the async nature of the {AsyncCompletions,chat.AsyncCompletions}.create method. see openai/openai-python#996 this means two things - 0. we cannot use iscoroutine in the recorder to detect async vs non 1. our mocks are inappropriately introducing identifiable async for (0), we update the iscoroutine check w/ detection of /v1/models, which is the only non-async function we mock & record. for (1), we could leave everything as is and assume (0) will catch errors. to be defensive, we update the unit tests to mock below create methods, allowing the true openai-python create() methods to be tested.
3 participants
What does this PR do?
the @required_args decorator in openai-python is masking the async nature of the {AsyncCompletions,chat.AsyncCompletions}.create method. see openai/openai-python#996
this means two things -
for (0), we update the iscoroutine check w/ detection of /v1/models, which is the only non-async function we mock & record.
for (1), we could leave everything as is and assume (0) will catch errors. to be defensive, we update the unit tests to mock below create methods, allowing the true openai-python create() methods to be tested.