Skip to content

Add blackscholes without AMS support in repo#186

Open
koparasy wants to merge 5 commits into
developfrom
features/simple-bench
Open

Add blackscholes without AMS support in repo#186
koparasy wants to merge 5 commits into
developfrom
features/simple-bench

Conversation

@koparasy
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v18.1.8) reports: 3 concern(s)
  • examples/simple/blackscholes/cpu_compute.cpp:107:3: warning: [clang-analyzer-deadcode.DeadStores]

    Value stored to 'xStrikePrice' is never read

      107 |   xStrikePrice = strike;
          |   ^              ~~~~~~
    /home/runner/work/AMS/AMS/examples/simple/blackscholes/cpu_compute.cpp:107:3: note: Value stored to 'xStrikePrice' is never read
      107 |   xStrikePrice = strike;
          |   ^              ~~~~~~
  • examples/simple/blackscholes/driver.cpp:18:10: error: [clang-diagnostic-error]

    'profile.hpp' file not found

       18 | #include "profile.hpp"
          |          ^~~~~~~~~~~~~
  • examples/simple/blackscholes/gpu_compute.cpp:4:10: error: [clang-diagnostic-error]

    'device_traits.hpp' file not found

        4 | #include "device_traits.hpp"
          |          ^~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

@lpottier
Copy link
Copy Markdown
Member

@koparasy is that example working?

@koparasy
Copy link
Copy Markdown
Member Author

Define working. The benchmark compiles and runs, it also provides necessary infrastructure to have GPU portable code in your examples without relying on raja or mfem and keep your examples code simpler.

It should build and run AFAIR. However, I believe it is not using the AMS API. That would be the next step..

@lpottier
Copy link
Copy Markdown
Member

@koparasy Okay thanks, that's what I was wondering (if it was running). I know it does not contain any AMS integration but that's fine. I was wondering why we never merged it.

@koparasy
Copy link
Copy Markdown
Member Author

TBH, I wanted to add also the AMS support before merging, which I didn't. The setup though gives a good baseline on how you can structure your examples with and without ams and with baselines.

@lpottier
Copy link
Copy Markdown
Member

It looks some files are missing: profile.hpp and device_traits.hpp.

@koparasy
Copy link
Copy Markdown
Member Author

You probably want this: examples/simple/include/profile.hpp placed on the wrong directory.
And likely this should get you close enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants