Add AMS Homogeneous and Heterogenous Graph data structures.#188
Draft
YohannDudouit wants to merge 9 commits into
Draft
Add AMS Homogeneous and Heterogenous Graph data structures.#188YohannDudouit wants to merge 9 commits into
YohannDudouit wants to merge 9 commits into
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Conversion operation from/to AMS from/to Torch graph representation
YohannDudouit
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Signed-off-by: Loic Pottier <[email protected]>
* Add support for int32_t and int64_t. * Fix typo/bug in AMSEOS. * Deactivating Dane tests * Add unit tests for int support. * Update tests/AMSlib/ams_interface/int_interface.cpp * Fix _elements used before initialization. * Fix HIP memory allocation and typo. --------- Signed-off-by: Loic Pottier <[email protected]> Co-authored-by: Loic Pottier <[email protected]>
- Conversion operation from/to AMS from/to Torch graph representation
…to yohann/graph-support
lpottier
reviewed
May 6, 2026
Member
lpottier
left a comment
lpottier
left a comment
There was a problem hiding this comment.
LGTM. If you can add some documentation for each function, I would like to start documenting AMS more rigorously using Doxygen style comments.
| { | ||
| typedef enum { AMS_SINGLE = 0, AMS_DOUBLE, AMS_UNKNOWN_TYPE } AMSDType; | ||
| typedef enum { | ||
| AMS_SINGLE = 0, |
Member
There was a problem hiding this comment.
At some point we will have to rename AMS_SINGLE -> AMS_FLOAT32 and AMS_DOUBLE -> AMS_FLOAT64
|
|
||
| static std::size_t hashCombine(std::size_t seed, std::size_t value) noexcept | ||
| { | ||
| seed ^= value + 0x9e3779b9u + (seed << 6) + (seed >> 2); |
Member
There was a problem hiding this comment.
What is the goal of that function / magic number? Can't we use a classic hashing function?
| namespace | ||
| { | ||
| template <typename T> | ||
| constexpr AMSDType scalar_to_ams_dtype() |
Member
There was a problem hiding this comment.
Update scalar_to_ams_dtype to scalarToAMSDtype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds graph data structures, both homogeneous and heterogeneous, to support Graph Neural Networks (GNNs) models.