Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "minor fixes" #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions derived_tables/user_facts.view.lkml
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,25 @@ view: user_facts {
dimension: user_id {
primary_key: yes
}
dimension_group: player_first_seen {
dimension: player_first_seen {
description: "Not for direct use, use for NDT"
type: time
type: date_time
}
dimension_group: player_last_seen {
dimension: player_last_seen {
description: "Not for direct use, use for NDT"
type: time
type: date_time
}

dimension_group: since_last_seen {
intervals: [day,hour,week,month]
type: duration
sql_start: ${player_last_seen_raw} ;;
sql_start: ${player_last_seen} ;;
sql_end: CURRENT_TIMESTAMP ;;
}
dimension_group: since_first_seen {
type: duration
intervals: [day,hour,week,month]
sql_start: ${player_first_seen_raw} ;;
sql_start: ${player_first_seen} ;;
sql_end: CURRENT_TIMESTAMP ;;
}

Expand Down
4 changes: 2 additions & 2 deletions gaming_block/events.view.lkml
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ dimension: drill_field {
dimension: days_since_user_signup {
type: number
description: "Days since first seen (from today)"
sql: DATE_DIFF(${current_date}, ${user_facts.player_first_seen_date}, DAY);;
sql: DATE_DIFF(${current_date}, ${user_facts.player_first_seen}, DAY);;
}


Expand All @@ -183,7 +183,7 @@ dimension: drill_field {
group_label: "Retention"
description: "Days since first seen (from event date)"
type: number
sql: DATE_DIFF(${event_date}, ${user_facts.player_first_seen_date}, DAY);;
sql: DATE_DIFF(${event_date}, ${user_facts.player_first_seen}, DAY);;
}

# D1
Expand Down
12 changes: 6 additions & 6 deletions lookml_dashboards/daily_pulse.dashboard.lookml
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@
type: single_value
fields: [events.d7_retention_rate]
filters:
user_facts.player_first_seen_date: 30 days ago for 30 days
user_facts.player_first_seen: 30 days ago for 30 days
limit: 500
column_limit: 50
note_state: collapsed
Expand All @@ -627,7 +627,7 @@
type: single_value
fields: [events.d1_retention_rate]
filters:
user_facts.player_first_seen_date: 30 days ago for 30 days
user_facts.player_first_seen: 30 days ago for 30 days
limit: 500
column_limit: 50
note_state: collapsed
Expand All @@ -651,7 +651,7 @@
type: single_value
fields: [events.d14_retention_rate]
filters:
user_facts.player_first_seen_date: 30 days ago for 30 days
user_facts.player_first_seen: 30 days ago for 30 days
limit: 500
column_limit: 50
note_state: collapsed
Expand Down Expand Up @@ -835,10 +835,10 @@
model: gaming
explore: events
type: looker_line
fields: [events.d1_retention_rate, user_facts.player_first_seen_date, events.d7_retention_rate]
fields: [events.d1_retention_rate, user_facts.player_first_seen, events.d7_retention_rate]
filters:
user_facts.player_first_seen_date: 30 days ago for 30 days
sorts: [user_facts.player_first_seen_date desc]
user_facts.player_first_seen: 30 days ago for 30 days
sorts: [user_facts.player_first_seen desc]
limit: 500
column_limit: 50
color_application:
Expand Down
4 changes: 2 additions & 2 deletions manifest.lkml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ constant: version_field {

## What is the game name field? (for schemas with multiple fields)
constant: game_name_field {
value: "game_name"
value: "device_platform"
}

## What is the user/player ID field?
Expand All @@ -39,7 +39,7 @@ constant: event_name_field {

## What is name of the acquisition cost field?
constant: acquisition_cost_field {
value: "install_cost"
value: "event_name"
}


Expand Down
2 changes: 1 addition & 1 deletion sessionization/sessions.view.lkml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ view: sessions {
FROM (
SELECT user_id,
@{timestamp_field},
SUM(is_new_session) OVER (ORDER BY user_id, @{timestamp_field}) AS unique_session_id,
, SUM(is_new_session) OVER (ORDER BY user_id, @{timestamp_field}) AS unique_session_id,
SUM(is_new_session) OVER (PARTITION BY user_id ORDER BY @{timestamp_field}) AS player_session_sequence
FROM ${last.SQL_TABLE_NAME} as final
) session
Expand Down