Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requirement for pip and poetry #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update requirement for pip and poetry #35

wants to merge 1 commit into from

Conversation

lwshanbd
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llvm-ir-dataset-utils ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 10:28pm

@lwshanbd
Copy link
Contributor Author

@boomanaiden154

boomanaiden154
boomanaiden154 requested changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't update the pipenv dependencies, which are canonical for the repository. You need to update Pipfile and then generate Pipfile.lock.

@lwshanbd
Copy link
Contributor Author

I updated the Pipfile and pyproject.toml. Then I use pipenv and poetry to generate both .lock.

boomanaiden154
boomanaiden154 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ludgerpaehler
Copy link
Contributor

@lwshanbd did you run poetry check against the new config? This is where I had to narrow the version down by a lot when I resolved the versions with poetry in the past.

@lwshanbd
Copy link
Contributor Author

Hi @ludgerpaehler, the poetry.lock is I generated by poetry lock. Should I do something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boomanaiden154 boomanaiden154 boomanaiden154 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwshanbd @ludgerpaehler @boomanaiden154