Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the dataset utlities for compiling files in parallel #36

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

andrewkallai
Copy link

No description provided.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llvm-ir-dataset-utils ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 11:27pm

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments.

Can the directory name be changed to something like compile_time_analysis_tools to be more specific?

…ments to batch creation script. Renamed directory and moved SLURM files for clarity. Added CC argument checking for clang in Makefile.
…fied Makefile for clarity. Modified slurm files to accomodate dataset download functionality. Added dataset download files to write the dataset from the HF api to disk.
… a seperate PR. Modified gitignore to ignore VIM undo and backup files.
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking reasonably good at this point.

Are you also able to add a short README.md within this folder that describes how to use these tools?

…relative time pass data collection. Added README for info and simplified batch script generation and csv creation.
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the CI failures.

…outputs.sh, modified README to shorten lines, modified write_ir_counts.py for improved functionality.
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants