Skip to content

[hlstool] add top-level-function option for calyx flow #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

[hlstool] add top-level-function option for calyx flow #8434

merged 2 commits into from
Apr 28, 2025

Conversation

KelvinChung2000
Copy link
Contributor

Exposing the --top-level-function in hlstool for calyx lowering

@KelvinChung2000 KelvinChung2000 changed the title [hlstool] add top-level-function option [hlstool] add top-level-function option for calyx flow Apr 22, 2025
@KelvinChung2000 KelvinChung2000 marked this pull request as draft April 22, 2025 11:28
@KelvinChung2000 KelvinChung2000 marked this pull request as ready for review April 22, 2025 11:47
mortbopet
mortbopet approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@mortbopet mortbopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add a test that exercises this option.

@jiahanxie353
Copy link
Contributor

LGTM! Are you able to hit the merge button? @KelvinChung2000

@KelvinChung2000
Copy link
Contributor Author

I do not have access to it

@jiahanxie353 jiahanxie353 merged commit 0ab7ab0 into llvm:main Apr 28, 2025
5 checks passed
@jiahanxie353
Copy link
Contributor

Merged!
Thanks for fixing it @KelvinChung2000 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortbopet mortbopet mortbopet approved these changes

@mikeurbach mikeurbach Awaiting requested review from mikeurbach mikeurbach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KelvinChung2000 @jiahanxie353 @mortbopet