Allow Bound-in layers under inline layers #8642
Draft
+481
−159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a circuit, we only know about the layers which have been declared. If we have an extmodule, it may have been defined under a different set of layers than what is in the current circuit. In particular, if there is a layer which we know about, but the extmodule does not, then the extmodule will not have a bind file for us to include. This commit adds a "knownlayer" declaration to extmodules, which is an explicit specification of the layers which an extmodule was defined with. For each bound-in layer that an extmodule knows about, we can assume that there will be a bindfile to include. Changes: FExtModule: Add a knownLayers property. Update the verifier so that, if a layer is mentioned by an enablelayer specification or port type, then that layer must be known by the exmodule. Bonus: implement verifySymbolUses for extmodules. FIRParser: add parsing for knownlayer declarations on extmodules. LowerLayersPass: Use the known-layers of extmodules while building the bindfiles for modules in the current circuit. If a module in the current circuit instantiates an extmodule, then that module's bindfiles will include the bindfiles for the known-layers of the extmodule. SpecializeLayers: Clean up known-layers when a layer is specialized away. FirEmitter: Emit knownlayer declarations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.