[CIR] Add support for __sync_swap builtin
#1971
Open
+73
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the __sync_swap builtin Signed-off-by: vishruth-thimmaiah <[email protected]>
vishruth-thimmaiah
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
changed the title
__sync_swap builtin
bcardosolopes
approved these changes
Nov 7, 2025
| // CHECK: cir.atomic.fetch(xchg, {{.*}} : !cir.ptr<!s32i>, {{.*}} : !s32i, seq_cst) fetch_first : !s32i | ||
|
|
||
| // LLVM-LABEL: @_Z4swapPii | ||
| // LLVM: atomicrmw xchg ptr {{.*}}, i32 {{.*}} seq_cst, align 4 |
There was a problem hiding this comment.
Nit: please add OGCG lines too (see clang/test/CIR/CodeGen/alignment.c for examples). No need to add it for the existing tests, just the new ones are fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
__sync_swapbuiltin.