[clang-tidy] Fix modernize-use-nullptr crash on 32-bit Windows
#160023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang-tools-extra Author: Victor Chernyakin (localspook) ChangesFixes #53778. See that issue for an explanation of the problem. Full diff: https://github.com/llvm/llvm-project/pull/160023.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
index c38fb3a01d287..782a10420f9cd 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
@@ -53,7 +53,7 @@ StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef<StringRef> NameList) {
unless(hasImplicitDestinationType(
qualType(matchers::matchesAnyListedTypeName(NameList)))));
- auto IsOrHasDescendant = [](auto InnerMatcher) {
+ auto IsOrHasDescendant = [](const auto &InnerMatcher) {
return anyOf(InnerMatcher, hasDescendant(InnerMatcher));
};
|
|
@llvm/pr-subscribers-clang-tidy Author: Victor Chernyakin (localspook) ChangesFixes #53778. See that issue for an explanation of the problem. Full diff: https://github.com/llvm/llvm-project/pull/160023.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
index c38fb3a01d287..782a10420f9cd 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
@@ -53,7 +53,7 @@ StatementMatcher makeCastSequenceMatcher(llvm::ArrayRef<StringRef> NameList) {
unless(hasImplicitDestinationType(
qualType(matchers::matchesAnyListedTypeName(NameList)))));
- auto IsOrHasDescendant = [](auto InnerMatcher) {
+ auto IsOrHasDescendant = [](const auto &InnerMatcher) {
return anyOf(InnerMatcher, hasDescendant(InnerMatcher));
};
|
localspook
requested review from
PiotrZSL,
carlosgalvezp,
EugeneZelenko,
5chmidti,
vbvictor and
HerrCai0907
|
Will be good idea to mention fix in Release Notes. |
|
I keep forgetting to do that >_< |
Co-authored-by: EugeneZelenko <[email protected]>
|
Awesome, thank you for looking into this! Do we have the possibility to verify this before merging? I read your analysis and I think it makes sense, but would of course be good to test that the fix does work. |
|
Sorry if I wasn't clear; I have a local x86 build of clang-tidy, I've verified that all the alternative fixes I've listed in the issue do work |
vbvictor
approved these changes
Sep 22, 2025
cc @AaronBallman as maintainer of AST matchers |
Should retry pinging after 6th of october (preferably give one more week), https://discourse.llvm.org/t/my-upcoming-availability/87851 |
|
Ooh, thank you, I wasn’t aware of that post. Since it says another maintainer can step in in the meantime, cc @Sirraide as maintainer of AST visitors, which seems like the next closest component |
AST matchers are something I’m very much not familiar w/ unfortunately (yes, there’s an AST visitor in there somewhere but it’s more than just that ;Þ) |
Co-authored-by: EugeneZelenko <[email protected]>
|
Ah, no worries then! |
HerrCai0907
approved these changes
Sep 23, 2025
|
|
|
I think we can merge this now and later take steps on how to avoid similar issues in the future. |
|
Fair enough, merging |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/15398 Here is the relevant piece of the build log for the reference |
|
Failure looks unrelated |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53778. See that issue for an explanation of the problem.