[mlir][vector] Update representation of insert/extract_strided_slice #101850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacDue
requested review from
antiagainst,
kuhar,
banach-space,
dcaballe,
hanhanW and
nicolasvasilache
as code owners
|
@llvm/pr-subscribers-mlir-spirv @llvm/pr-subscribers-mlir Author: Benjamin Maxwell (MacDue) ChangesThis commit updates the representation of both Because previously the offsets, strides, and sizes were in the attribute dictionary (with no special syntax), simply replacing the attribute types with So since a syntax break is mostly unavoidable this commit also tackles a long-standing TODO: This is done by introducing a new With this:
To: (matching the TODO) And To: (inspired by the TODO) Almost all test changes were done automatically via This PR is split into multiple commits to make the changes more understandable.
Patch is 354.52 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/101850.diff 44 Files Affected:
|
|
@llvm/pr-subscribers-backend-amdgpu Author: Benjamin Maxwell (MacDue) ChangesThis commit updates the representation of both Because previously the offsets, strides, and sizes were in the attribute dictionary (with no special syntax), simply replacing the attribute types with So since a syntax break is mostly unavoidable this commit also tackles a long-standing TODO: This is done by introducing a new With this:
To: (matching the TODO) And To: (inspired by the TODO) Almost all test changes were done automatically via This PR is split into multiple commits to make the changes more understandable.
Patch is 354.52 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/101850.diff 44 Files Affected:
|
|
This is the most ambitious change based on #100997. Note: This PR is not urgent! It's just something I think would be nice to have 🙂 |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
MacDue
force-pushed
the
insert_extract_slice
branch
2 times, most recently
from
13457fe to
7034b77
Compare
MacDue
force-pushed
the
insert_extract_slice
branch
from
7034b77 to
159f822
Compare
joker-eph
reviewed
Aug 5, 2024
| printer << sizes[strideIdx] << ':'; | ||
| printer << strides[strideIdx] << ']'; | ||
| } | ||
| } |
There was a problem hiding this comment.
There seems to be an assumption about the size of all the arrays, but I don't see the invariant enforced in a verifier?
There was a problem hiding this comment.
I didn't add a verifier for the attribute, as the constraints are enforced within the ops (right now). I think some of those constraints could be factored out to the StridedSliceAttr though 👍
There was a problem hiding this comment.
Going to leave this for a future patch now it's not needed for the printer/parser (which just uses the current syntax).
This commit updates the representation of both extract_strided_slice and insert_strided_slice to primitive arrays of int64_ts, rather than ArrayAttrs of IntegerAttrs. This prevents a lot of boilerplate conversions between IntegerAttr and int64_t. This is done by adding a new `StridedSliceAttr` which matches the previous syntax and can be used for both operations. It may also be possible to explore alternate slice syntax for the `StridedSliceAttr` in future.
MacDue
force-pushed
the
insert_extract_slice
branch
from
159f822 to
c5b35e2
Compare
MacDue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the representation of both extract_strided_slice and insert_strided_slice to primitive arrays of int64_ts, rather than ArrayAttrs of IntegerAttrs. This prevents a lot of boilerplate conversions between IntegerAttr and int64_t.
This is done by adding a new
StridedSliceAttrwhich matches the previous syntax and can be used for both operations.It may also be possible to explore alternate slice syntax for the
StridedSliceAttrin future.