Skip to content

[Clang][LoongArch] Match GCC behaviour when parsing FPRs in asm clobbers #138391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

[Clang][LoongArch] Match GCC behaviour when parsing FPRs in asm clobbers #138391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 40 additions & 32 deletions clang/lib/Basic/Targets/LoongArch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,38 +81,46 @@ LoongArchTargetInfo::getGCCRegAliases() const {
{{"s6", "$s6", "r29"}, "$r29"},
{{"s7", "$s7", "r30"}, "$r30"},
{{"s8", "$s8", "r31"}, "$r31"},
{{"$fa0"}, "$f0"},
{{"$fa1"}, "$f1"},
{{"$fa2"}, "$f2"},
{{"$fa3"}, "$f3"},
{{"$fa4"}, "$f4"},
{{"$fa5"}, "$f5"},
{{"$fa6"}, "$f6"},
{{"$fa7"}, "$f7"},
{{"$ft0"}, "$f8"},
{{"$ft1"}, "$f9"},
{{"$ft2"}, "$f10"},
{{"$ft3"}, "$f11"},
{{"$ft4"}, "$f12"},
{{"$ft5"}, "$f13"},
{{"$ft6"}, "$f14"},
{{"$ft7"}, "$f15"},
{{"$ft8"}, "$f16"},
{{"$ft9"}, "$f17"},
{{"$ft10"}, "$f18"},
{{"$ft11"}, "$f19"},
{{"$ft12"}, "$f20"},
{{"$ft13"}, "$f21"},
{{"$ft14"}, "$f22"},
{{"$ft15"}, "$f23"},
{{"$fs0"}, "$f24"},
{{"$fs1"}, "$f25"},
{{"$fs2"}, "$f26"},
{{"$fs3"}, "$f27"},
{{"$fs4"}, "$f28"},
{{"$fs5"}, "$f29"},
{{"$fs6"}, "$f30"},
{{"$fs7"}, "$f31"},
{{"fa0", "$fa0", "f0"}, "$f0"},
{{"fa1", "$fa1", "f1"}, "$f1"},
{{"fa2", "$fa2", "f2"}, "$f2"},
{{"fa3", "$fa3", "f3"}, "$f3"},
{{"fa4", "$fa4", "f4"}, "$f4"},
{{"fa5", "$fa5", "f5"}, "$f5"},
{{"fa6", "$fa6", "f6"}, "$f6"},
{{"fa7", "$fa7", "f7"}, "$f7"},
{{"ft0", "$ft0", "f8"}, "$f8"},
{{"ft1", "$ft1", "f9"}, "$f9"},
{{"ft2", "$ft2", "f10"}, "$f10"},
{{"ft3", "$ft3", "f11"}, "$f11"},
{{"ft4", "$ft4", "f12"}, "$f12"},
{{"ft5", "$ft5", "f13"}, "$f13"},
{{"ft6", "$ft6", "f14"}, "$f14"},
{{"ft7", "$ft7", "f15"}, "$f15"},
{{"ft8", "$ft8", "f16"}, "$f16"},
{{"ft9", "$ft9", "f17"}, "$f17"},
{{"ft10", "$ft10", "f18"}, "$f18"},
{{"ft11", "$ft11", "f19"}, "$f19"},
{{"ft12", "$ft12", "f20"}, "$f20"},
{{"ft13", "$ft13", "f21"}, "$f21"},
{{"ft14", "$ft14", "f22"}, "$f22"},
{{"ft15", "$ft15", "f23"}, "$f23"},
{{"fs0", "$fs0", "f24"}, "$f24"},
{{"fs1", "$fs1", "f25"}, "$f25"},
{{"fs2", "$fs2", "f26"}, "$f26"},
{{"fs3", "$fs3", "f27"}, "$f27"},
{{"fs4", "$fs4", "f28"}, "$f28"},
{{"fs5", "$fs5", "f29"}, "$f29"},
{{"fs6", "$fs6", "f30"}, "$f30"},
{{"fs7", "$fs7", "f31"}, "$f31"},
{{"fcc0"}, "$fcc0"},
{{"fcc1"}, "$fcc1"},
{{"fcc2"}, "$fcc2"},
{{"fcc3"}, "$fcc3"},
{{"fcc4"}, "$fcc4"},
{{"fcc5"}, "$fcc5"},
{{"fcc6"}, "$fcc6"},
{{"fcc7"}, "$fcc7"},
};
return llvm::ArrayRef(GCCRegAliases);
}
Expand Down
9 changes: 0 additions & 9 deletions clang/test/CodeGen/LoongArch/inline-asm-gcc-regs-error.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,4 @@ void test(void) {
register float a1 asm ("$f32");
// CHECK: :[[#@LINE+1]]:24: error: unknown register name '$foo' in asm
register int a2 asm ("$foo");

/// Names not prefixed with '$' are invalid.

// CHECK: :[[#@LINE+1]]:26: error: unknown register name 'f0' in asm
register float a5 asm ("f0");
// CHECK: :[[#@LINE+1]]:26: error: unknown register name 'fa0' in asm
register float a6 asm ("fa0");
// CHECK: :[[#@LINE+1]]:15: error: unknown register name 'fcc0' in asm
asm ("" ::: "fcc0");
}
62 changes: 46 additions & 16 deletions clang/test/CodeGen/LoongArch/inline-asm-gcc-regs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
/// Check GCC register names and alias can be used in register variable definition.

// CHECK-LABEL: @test_r0
// CHECK: call void asm sideeffect "", "{$r0}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r0}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r0}"(i32 undef)
void test_r0() {
register int a asm ("$r0");
register int b asm ("r0");
Expand All @@ -13,7 +14,8 @@ void test_r0() {
}

// CHECK-LABEL: @test_r12
// CHECK: call void asm sideeffect "", "{$r12}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r12}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r12}"(i32 undef)
void test_r12() {
register int a asm ("$r12");
register int b asm ("r12");
Expand All @@ -22,7 +24,8 @@ void test_r12() {
}

// CHECK-LABEL: @test_r31
// CHECK: call void asm sideeffect "", "{$r31}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r31}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r31}"(i32 undef)
void test_r31() {
register int a asm ("$r31");
register int b asm ("r31");
Expand All @@ -31,7 +34,8 @@ void test_r31() {
}

// CHECK-LABEL: @test_zero
// CHECK: call void asm sideeffect "", "{$r0}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r0}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r0}"(i32 undef)
void test_zero() {
register int a asm ("$zero");
register int b asm ("zero");
Expand All @@ -40,7 +44,8 @@ void test_zero() {
}

// CHECK-LABEL: @test_a0
// CHECK: call void asm sideeffect "", "{$r4}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r4}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r4}"(i32 undef)
void test_a0() {
register int a asm ("$a0");
register int b asm ("a0");
Expand All @@ -49,7 +54,8 @@ void test_a0() {
}

// CHECK-LABEL: @test_t1
// CHECK: call void asm sideeffect "", "{$r13}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r13}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r13}"(i32 undef)
void test_t1() {
register int a asm ("$t1");
register int b asm ("t1");
Expand All @@ -58,7 +64,8 @@ void test_t1() {
}

// CHECK-LABEL: @test_fp
// CHECK: call void asm sideeffect "", "{$r22}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r22}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r22}"(i32 undef)
void test_fp() {
register int a asm ("$fp");
register int b asm ("fp");
Expand All @@ -67,7 +74,8 @@ void test_fp() {
}

// CHECK-LABEL: @test_s2
// CHECK: call void asm sideeffect "", "{$r25}"(i32 undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$r25}"(i32 undef)
// CHECK-NOT: call void asm sideeffect "", "{$r25}"(i32 undef)
void test_s2() {
register int a asm ("$s2");
register int b asm ("s2");
Expand All @@ -76,51 +84,73 @@ void test_s2() {
}

// CHECK-LABEL: @test_f0
// CHECK: call void asm sideeffect "", "{$f0}"(float undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$f0}"(float undef)
// CHECK-NOT: call void asm sideeffect "", "{$f0}"(float undef)
void test_f0() {
register float a asm ("$f0");
register float b asm ("f0");
asm ("" :: "f" (a));
asm ("" :: "f" (b));
}

// CHECK-LABEL: @test_f14
// CHECK: call void asm sideeffect "", "{$f14}"(float undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$f14}"(float undef)
// CHECK-NOT: call void asm sideeffect "", "{$f14}"(float undef)
void test_f14() {
register float a asm ("$f14");
register float b asm ("f14");
asm ("" :: "f" (a));
asm ("" :: "f" (b));
}

// CHECK-LABEL: @test_f31
// CHECK: call void asm sideeffect "", "{$f31}"(float undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$f31}"(float undef)
// CHECK-NOT: call void asm sideeffect "", "{$f31}"(float undef)
void test_f31() {
register float a asm ("$f31");
register float b asm ("f31");
asm ("" :: "f" (a));
asm ("" :: "f" (b));
}

// CHECK-LABEL: @test_fa0
// CHECK: call void asm sideeffect "", "{$f0}"(float undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$f0}"(float undef)
// CHECK-NOT: call void asm sideeffect "", "{$f0}"(float undef)
void test_fa0() {
register float a asm ("$fa0");
register float b asm ("fa0");
asm ("" :: "f" (a));
asm ("" :: "f" (b));
}

// CHECK-LABEL: @test_ft1
// CHECK: call void asm sideeffect "", "{$f9}"(float undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$f9}"(float undef)
// CHECK-NOT: call void asm sideeffect "", "{$f9}"(float undef)
void test_ft1() {
register float a asm ("$ft1");
register float b asm ("ft1");
asm ("" :: "f" (a));
asm ("" :: "f" (b));
}

// CHECK-LABEL: @test_fs2
// CHECK: call void asm sideeffect "", "{$f26}"(float undef)
// CHECK-COUNT-2: call void asm sideeffect "", "{$f26}"(float undef)
// CHECK-NOT: call void asm sideeffect "", "{$f26}"(float undef)
void test_fs2() {
register float a asm ("$fs2");
register float b asm ("fs2");
asm ("" :: "f" (a));
asm ("" :: "f" (b));
}

// CHECK-LABEL: @test_fcc
// CHECK: call void asm sideeffect "", "~{$fcc0}"()
// CHECK: call void asm sideeffect "", "~{$fcc7}"()
// CHECK-COUNT-2: call void asm sideeffect "", "~{$fcc0}"()
// CHECK-NOT: call void asm sideeffect "", "~{$fcc0}"()
// CHECK-COUNT-2: call void asm sideeffect "", "~{$fcc7}"()
// CHECK-NOT: call void asm sideeffect "", "~{$fcc7}"()
void test_fcc() {
asm ("" ::: "$fcc0");
asm ("" ::: "fcc0");
asm ("" ::: "$fcc7");
asm ("" ::: "fcc7");
}
Loading