Skip to content

[NFC] [sanitizer] fix inaccurate comment #145809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

fmayer
Copy link
Contributor

@fmayer fmayer commented Jun 25, 2025

No description provided.

Created using spr 1.3.4
@fmayer fmayer requested a review from thurstond June 25, 2025 23:20
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Jun 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 25, 2025

@llvm/pr-subscribers-clang

Author: Florian Mayer (fmayer)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/145809.diff

1 Files Affected:

  • (modified) clang/include/clang/Basic/Sanitizers.h (+2-2)
diff --git a/clang/include/clang/Basic/Sanitizers.h b/clang/include/clang/Basic/Sanitizers.h
index 3782deb5962bc..b299de99157e7 100644
--- a/clang/include/clang/Basic/Sanitizers.h
+++ b/clang/include/clang/Basic/Sanitizers.h
@@ -218,8 +218,8 @@ bool parseSanitizerWeightedValue(StringRef Value, bool AllowGroups,
 void serializeSanitizerSet(SanitizerSet Set,
                            SmallVectorImpl<StringRef> &Values);
 
-/// Serialize a SanitizerMaskCutoffs into values for -fsanitize= or
-/// -fno-sanitize=.
+/// Serialize a SanitizerMaskCutoffs into values for
+// -fsanitize-skip-hot-cutoff=.
 void serializeSanitizerMaskCutoffs(const SanitizerMaskCutoffs &Cutoffs,
                                    SmallVectorImpl<std::string> &Values);
 

Copy link
Contributor

@thurstond thurstond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing about this function that is specific to -fsanitize-skip-hot-cutoffs. It's general enough that it could be used for any future -fsanitize- flags that need cutoffs.

@fmayer
Copy link
Contributor Author

fmayer commented Jun 25, 2025

There is nothing about this function that is specific to -fsanitize-skip-hot-cutoffs. It's general enough that it could be used for any future -fsanitize- flags that need cutoffs.

So, just remove the "... for fsanitize"?

Created using spr 1.3.4
@fmayer fmayer requested a review from thurstond June 25, 2025 23:30
@thurstond
Copy link
Contributor

There is nothing about this function that is specific to -fsanitize-skip-hot-cutoffs. It's general enough that it could be used for any future -fsanitize- flags that need cutoffs.

So, just remove the "... for fsanitize"?

Yes. Drop the " for -fsanitize= or /// -fno-sanitize=". Just "Serialize a SanitizerMaskCutoffs into values." It's cleaner.

@fmayer fmayer merged commit 1979750 into main Jun 25, 2025
5 of 7 checks passed
@fmayer fmayer deleted the users/fmayer/spr/nfc-sanitizer-fix-inaccurate-comment branch June 25, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants