Skip to content

[mlir][tblgen] Fix test definition names to reflect expected valid results (NFC) #146243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

xlauko
Copy link
Contributor

@xlauko xlauko commented Jun 28, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jun 28, 2025

@llvm/pr-subscribers-mlir

Author: Henrich Lauko (xlauko)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/146243.diff

1 Files Affected:

  • (modified) mlir/test/mlir-tblgen/op-format-spec.td (+3-3)
diff --git a/mlir/test/mlir-tblgen/op-format-spec.td b/mlir/test/mlir-tblgen/op-format-spec.td
index 03b63f42c7767..1541cd09f53e0 100644
--- a/mlir/test/mlir-tblgen/op-format-spec.td
+++ b/mlir/test/mlir-tblgen/op-format-spec.td
@@ -95,7 +95,7 @@ def DirectiveRegionsValid : TestFormat_Op<[{
 //===----------------------------------------------------------------------===//
 
 // CHECK-NOT: error:
-def DirectiveResultsInvalidA : TestFormat_Op<[{
+def DirectiveResultsValid : TestFormat_Op<[{
   type(results) attr-dict
 }]>;
 
@@ -104,7 +104,7 @@ def DirectiveResultsInvalidA : TestFormat_Op<[{
 //===----------------------------------------------------------------------===//
 
 // CHECK-NOT: error:
-def DirectiveSuccessorsInvalidA : TestFormat_Op<[{
+def DirectiveSuccessorsValid : TestFormat_Op<[{
   successors attr-dict
 }]>;
 
@@ -167,7 +167,7 @@ def OptionalValidA : TestFormat_Op<[{
 //===----------------------------------------------------------------------===//
 
 // CHECK-NOT: error
-def StringInvalidA : TestFormat_Op<[{ custom<Foo>("foo") attr-dict }]>;
+def StringValid : TestFormat_Op<[{ custom<Foo>("foo") attr-dict }]>;
 
 //===----------------------------------------------------------------------===//
 // Variables

@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-format-spec-typo branch from bc29f7f to e2ad5d5 Compare June 28, 2025 21:22
@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-region-ref-parser branch from 9719d94 to 43e2282 Compare June 28, 2025 21:22
@xlauko
Copy link
Contributor Author

xlauko commented Jun 28, 2025

@xlauko xlauko requested review from jpienaar and zero9178 June 28, 2025 21:27
Copy link
Member

@zero9178 zero9178 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-region-ref-parser branch from 43e2282 to 8923501 Compare June 30, 2025 20:37
@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-format-spec-typo branch from e2ad5d5 to 36536e8 Compare June 30, 2025 20:37
@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-region-ref-parser branch from 8923501 to a574831 Compare June 30, 2025 20:41
@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-format-spec-typo branch 2 times, most recently from 24941e8 to e0c10a2 Compare July 1, 2025 07:30
@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-region-ref-parser branch from a574831 to 350e6d4 Compare July 1, 2025 07:30
Copy link
Contributor Author

xlauko commented Jul 1, 2025

Merge activity

  • Jul 1, 10:27 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 1, 10:31 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 1, 10:35 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 1, 10:37 AM UTC: @xlauko merged this pull request with Graphite.

@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-region-ref-parser branch from 350e6d4 to 2701a0a Compare July 1, 2025 10:28
Base automatically changed from users/xlauko/mlir-tblgen-region-ref-parser to main July 1, 2025 10:30
@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-format-spec-typo branch from e0c10a2 to 9bfcc35 Compare July 1, 2025 10:31
@xlauko xlauko force-pushed the users/xlauko/mlir-tblgen-format-spec-typo branch from 9bfcc35 to 8fe912a Compare July 1, 2025 10:34
@xlauko xlauko merged commit 37d30d9 into main Jul 1, 2025
5 of 7 checks passed
@xlauko xlauko deleted the users/xlauko/mlir-tblgen-format-spec-typo branch July 1, 2025 10:37
rlavaee pushed a commit to rlavaee/llvm-project that referenced this pull request Jul 1, 2025
rlavaee pushed a commit to rlavaee/llvm-project that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants