[mlir-tblgen] Emit named operand indices #146839
Draft
+22
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An operation's operands are defined by the
arguments
field in the tablegen definition. mlir-tblgen generates accessors for them:getXYZ()
andsetXYZ(...)
to set an operation's operands without knowing the operand's index, but it does not expose the operand index itself. Yet some use cases requires knowing the operand index that is now covered by just getters and setters. For instance:mlir::OpOperand
, find out whether it is a specific argument (from thearguments
field in the.td
file)AttrSizedOperandSegments
), get the value to pass togetODSOperands
orgetODSOperandIndexAndLength
.Emitting a named constant avoids hardcoding the index in the source as magic constant, such as
2
inllvm-project/mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
Line 244 in d56c06e
Extracted out of #144785