Skip to content

[mlir][xevm] Add missing static value utils dependency #147051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

adam-smnk
Copy link
Contributor

Fixes missing symbol linker error from #144811

@llvmbot
Copy link
Member

llvmbot commented Jul 4, 2025

@llvm/pr-subscribers-mlir-llvm

Author: Adam Siemieniuk (adam-smnk)

Changes

Fixes missing symbol linker error from #144811


Full diff: https://github.com/llvm/llvm-project/pull/147051.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/LLVMIR/CMakeLists.txt (+1)
diff --git a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
index 67081ca61e6e5..d987b72e98354 100644
--- a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
+++ b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
@@ -128,6 +128,7 @@ add_mlir_dialect_library(MLIRXeVMDialect
   Core
 
   LINK_LIBS PUBLIC
+  MLIRDialectUtils
   MLIRIR
   MLIRLLVMDialect
   MLIRSideEffectInterfaces

@llvmbot
Copy link
Member

llvmbot commented Jul 4, 2025

@llvm/pr-subscribers-mlir

Author: Adam Siemieniuk (adam-smnk)

Changes

Fixes missing symbol linker error from #144811


Full diff: https://github.com/llvm/llvm-project/pull/147051.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/LLVMIR/CMakeLists.txt (+1)
diff --git a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
index 67081ca61e6e5..d987b72e98354 100644
--- a/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
+++ b/mlir/lib/Dialect/LLVMIR/CMakeLists.txt
@@ -128,6 +128,7 @@ add_mlir_dialect_library(MLIRXeVMDialect
   Core
 
   LINK_LIBS PUBLIC
+  MLIRDialectUtils
   MLIRIR
   MLIRLLVMDialect
   MLIRSideEffectInterfaces

@rengolin
Copy link
Member

rengolin commented Jul 4, 2025

Linux failures due to unstable FIR tests, ignore.

  Failed Tests (2):
    Flang :: Fir/convert-nontemporal-to-llvm.fir
    Flang :: Fir/simd-nontemporal.fir

@adam-smnk adam-smnk merged commit 0b4941a into llvm:main Jul 4, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants