Skip to content

[IR2Vec] Add embeddings mode to llvm-ir2vec tool #147844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: users/svkeerthy/07-09-ir2vec_tool
Choose a base branch
from

Conversation

svkeerthy
Copy link
Contributor

@svkeerthy svkeerthy commented Jul 9, 2025

Add embedding generation functionality to the llvm-ir2vec tool, complementing the existing triplet generation mode.

This change completes the IR2Vec tool by adding the embedding generation functionality, which was previously mentioned as a TODO item. The tool now supports both triplet generation for vocabulary training and embedding generation using a trained vocabulary.

@svkeerthy svkeerthy changed the title IR2Vec Tool Enhancements [IR2Vec] Add embeddings mode to llvm-ir2vec tool Jul 9, 2025
@svkeerthy svkeerthy marked this pull request as ready for review July 9, 2025 22:55
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Premerge failures here also look relevant.

@@ -0,0 +1,73 @@
; RUN: llvm-ir2vec --mode=embeddings --ir2vec-vocab-path=%S/../../Analysis/IR2Vec/Inputs/dummy_3D_nonzero_opc_vocab.json %s | FileCheck %s -check-prefix=CHECK-DEFAULT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given you access %S../../Analysis/IR2Vec/Inputs so often, I'm wondering if it makes sense to add a lit substitution. Maybe something like %ir2vec_test_vocab or something.

@svkeerthy svkeerthy force-pushed the users/svkeerthy/07-09-ir2vec_tool branch from 7c4d86d to 5f1f3fe Compare July 11, 2025 19:54
@svkeerthy svkeerthy force-pushed the users/svkeerthy/07-09-ir2vec_tool_enhancements branch 2 times, most recently from bf757c0 to 684d298 Compare July 11, 2025 21:35
Copy link

github-actions bot commented Jul 11, 2025

✅ With the latest revision this PR passed the Python code formatter.

@svkeerthy svkeerthy force-pushed the users/svkeerthy/07-09-ir2vec_tool_enhancements branch from 684d298 to 2d88b38 Compare July 11, 2025 21:43
@svkeerthy svkeerthy force-pushed the users/svkeerthy/07-09-ir2vec_tool_enhancements branch from 2d88b38 to 6fd2dca Compare July 11, 2025 22:10
@svkeerthy svkeerthy requested a review from boomanaiden154 July 11, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants