Skip to content

[CI][Github] Version pin packages in windows container #148319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+7 −2
Open

[CI][Github] Version pin packages in windows container #148319

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4df379e
[𝘀𝗽𝗿] changes to main this commit is based on
boomanaiden154 Jul 12, 2025
8101ab1
[𝘀𝗽𝗿] initial version
boomanaiden154 Jul 12, 2025
80a1fee
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Jul 14, 2025
c87f04a
rebase
boomanaiden154 Jul 14, 2025
46e896a
[𝘀𝗽𝗿] changes introduced through rebase
boomanaiden154 Jul 14, 2025
ad922b2
rebase
boomanaiden154 Jul 14, 2025
af16587
feedback
boomanaiden154 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/containers/github-action-ci-windows/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,16 @@ RUN regsvr32 /S "C:\BuildTools\DIA SDK\bin\amd64\msdia140.dll" & \

# install tools as described in https://llvm.org/docs/GettingStartedVS.html
# and a few more that were not documented...
RUN choco install -y ninja git sccache
# Pin an older version of Python; the current Python 3.10 fails when
# doing "pip install" for the other dependencies, as it fails to find libxml
# while compiling some package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably update the comment as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still pinning to an older version of python though (for that reason). At some point we need to bump the python version and figure out why it fails to install, but for now it's stuck at 3.9.7.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant you should update the comment to explain why we're pinning the other packages as well. Currently the comment says (paraphrased) "we're pinning Python" and then we proceed to pin not only Python and but 3 other packages, with no explanation or mention of the other three.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry for the misunderstanding.

I've added some additional text to describe why we're version pinning the rest of the packages.

RUN choco install -y python3 --version 3.9.7
# We version pin the other packages as well to ensure the container build is as
# reproducible as possible to prevent issues when upgrading only part of the
# container.
RUN choco install -y ninja --version 1.13.1 && \
choco install -y git --version 2.50.1 && \
choco install -y sccache --version 0.10.0 && \
choco install -y python3 --version 3.9.7

# Testing requires psutil
RUN pip install psutil
Expand Down
Loading