[mlir][spirv] Remove function-decorations-asserts.mlir
#164383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is fragile as it relies on the `--debug` flag to test an internal behaviour. This address discussion in llvm#164319.
|
@llvm/pr-subscribers-mlir-spirv Author: Igor Wodiany (IgWod-IMG) ChangesThe test is fragile as it relies on the Full diff: https://github.com/llvm/llvm-project/pull/164383.diff 1 Files Affected:
diff --git a/mlir/test/Target/SPIRV/function-decorations-asserts.mlir b/mlir/test/Target/SPIRV/function-decorations-asserts.mlir
deleted file mode 100644
index ebdb9fb1e75e3..0000000000000
--- a/mlir/test/Target/SPIRV/function-decorations-asserts.mlir
+++ /dev/null
@@ -1,20 +0,0 @@
-// REQUIRES: asserts
-// RUN: mlir-translate --no-implicit-module --test-spirv-roundtrip --split-input-file --debug %s | FileCheck %s
-
-spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> {
- spirv.func @linkage_attr_test_kernel() "DontInline" attributes {} {
- %uchar_0 = spirv.Constant 0 : i8
- %ushort_1 = spirv.Constant 1 : i16
- %uint_0 = spirv.Constant 0 : i32
- spirv.FunctionCall @outside.func.with.linkage(%uchar_0):(i8) -> ()
- spirv.Return
- }
- // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = "outside.func", linkage_type = <Import>>
- spirv.func @outside.func.with.linkage(%arg0 : i8) -> () "Pure" attributes {
- linkage_attributes=#spirv.linkage_attributes<
- linkage_name="outside.func",
- linkage_type=<Import>
- >
- }
- spirv.func @inside.func() -> () "Pure" attributes {} {spirv.Return}
-}
|
|
@llvm/pr-subscribers-mlir Author: Igor Wodiany (IgWod-IMG) ChangesThe test is fragile as it relies on the Full diff: https://github.com/llvm/llvm-project/pull/164383.diff 1 Files Affected:
diff --git a/mlir/test/Target/SPIRV/function-decorations-asserts.mlir b/mlir/test/Target/SPIRV/function-decorations-asserts.mlir
deleted file mode 100644
index ebdb9fb1e75e3..0000000000000
--- a/mlir/test/Target/SPIRV/function-decorations-asserts.mlir
+++ /dev/null
@@ -1,20 +0,0 @@
-// REQUIRES: asserts
-// RUN: mlir-translate --no-implicit-module --test-spirv-roundtrip --split-input-file --debug %s | FileCheck %s
-
-spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader, Linkage], []> {
- spirv.func @linkage_attr_test_kernel() "DontInline" attributes {} {
- %uchar_0 = spirv.Constant 0 : i8
- %ushort_1 = spirv.Constant 1 : i16
- %uint_0 = spirv.Constant 0 : i32
- spirv.FunctionCall @outside.func.with.linkage(%uchar_0):(i8) -> ()
- spirv.Return
- }
- // CHECK: linkage_attributes = #spirv.linkage_attributes<linkage_name = "outside.func", linkage_type = <Import>>
- spirv.func @outside.func.with.linkage(%arg0 : i8) -> () "Pure" attributes {
- linkage_attributes=#spirv.linkage_attributes<
- linkage_name="outside.func",
- linkage_type=<Import>
- >
- }
- spirv.func @inside.func() -> () "Pure" attributes {} {spirv.Return}
-}
|
kuhar
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is fragile as it relies on the
--debugflag to test an internal behaviour. This addresses discussion in #164319.