-
Notifications
You must be signed in to change notification settings - Fork 15k
[RISCV] Add short forward branch support for min, max, maxu and minu
#164394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1698,6 +1698,18 @@ unsigned getPredicatedOpcode(unsigned Opcode) { | |
| case RISCV::AND: return RISCV::PseudoCCAND; break; | ||
| case RISCV::OR: return RISCV::PseudoCCOR; break; | ||
| case RISCV::XOR: return RISCV::PseudoCCXOR; break; | ||
| case RISCV::MAX: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. Were the changes made by clang-format? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We really shouldn't have an unreachable There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Patch to remove them #164481 |
||
| return RISCV::PseudoCCMAX; | ||
| break; | ||
| case RISCV::MAXU: | ||
| return RISCV::PseudoCCMAXU; | ||
| break; | ||
| case RISCV::MIN: | ||
| return RISCV::PseudoCCMIN; | ||
| break; | ||
| case RISCV::MINU: | ||
| return RISCV::PseudoCCMINU; | ||
| break; | ||
|
|
||
| case RISCV::ADDI: return RISCV::PseudoCCADDI; break; | ||
| case RISCV::SLLI: return RISCV::PseudoCCSLLI; break; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have a consistent coding style. Were the changes here made by clang-format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the changes were made by clang-format. When I had the changes consistent with the coding style here, Then PR check of clang-format failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a clang-format off/on directive around the switch.