-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[DAGCombiner] Relax nsz constraint with fp->int->fp optimizations #164503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guy-david
wants to merge
1
commit into
users/guy-david/dag-combine-fp-to-int-to-fp
Choose a base branch
from
users/guy-david/dag-combine-fp-to-int-to-fp-sign-insensitive
base: users/guy-david/dag-combine-fp-to-int-to-fp
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6075,6 +6075,35 @@ bool SelectionDAG::isKnownNeverZeroFloat(SDValue Op) const { | |
| Op, [](ConstantFPSDNode *C) { return !C->isZero(); }); | ||
| } | ||
|
|
||
| bool SelectionDAG::allUsesSignedZeroInsensitive(SDValue Op) const { | ||
| assert(Op.getValueType().isFloatingPoint()); | ||
| return all_of(Op->uses(), [&](SDUse &Use) { | ||
| SDNode *User = Use.getUser(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This lambda should be pulled out into its own freestanding function. At least the IR has some version of this already |
||
| unsigned OperandNo = Use.getOperandNo(); | ||
|
|
||
| // Check if this use is insensitive to the sign of zero | ||
| switch (User->getOpcode()) { | ||
| case ISD::SETCC: | ||
| // Comparisons: IEEE-754 specifies +0.0 == -0.0. | ||
| case ISD::FABS: | ||
| // fabs always produces +0.0. | ||
| return true; | ||
| case ISD::FCOPYSIGN: | ||
| // copysign overwrites the sign bit of the first operand. | ||
| return OperandNo == 0; | ||
| case ISD::FADD: | ||
| case ISD::FSUB: { | ||
| // Arithmetic with non-zero constants fixes the uncertainty around the | ||
| // sign bit. | ||
| SDValue Other = User->getOperand(1 - OperandNo); | ||
| return isKnownNeverZeroFloat(Other); | ||
| } | ||
| default: | ||
| return false; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| bool SelectionDAG::isKnownNeverZero(SDValue Op, unsigned Depth) const { | ||
| if (Depth >= MaxRecursionDepth) | ||
| return false; // Limit search depth. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combines that require looking at all uses are not ideal. This should have some bounds on the number of uses.
Alternatively, this is so far reaching, maybe we should have a simplify-demanded style optimization to deal with this case, applied from canonicalizing uses