[libclc] Delete wrong implementation nvptx clc_isinf#205699
Merged
Merged
Conversation
The file calls __nv_isinf which return 1 for true on vector input, while the generic clc_isinf which return -1 for true on vector input. Using nvptx clc_isinf in OpenCL isinf violates OpenCL spec. Found the issue in intel/llvm#22413
jhuber6
approved these changes
Jun 25, 2026
jhuber6
left a comment
jhuber6
left a comment
Contributor
There was a problem hiding this comment.
Honestly we could probably replace a lot of old nv_ functions entirely. That would probably be a noble goal of this, but people may expect these functions to remain bitwise identical.
Contributor
Author
|
some libclc nvptx math function still uses |
Contributor
isinf cannot go wrong. There is no legitimate reason to provide an intrinsic for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file calls __nv_isinf which return 1 for true on vector input, while the generic clc_isinf which return -1 for true on vector input. Using nvptx clc_isinf in OpenCL isinf violates OpenCL spec.
Found the issue in intel/llvm#22413