fix: unknown target 'check-torch-mlir-python' #4335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking through
development.md
, runningcmake --build build --target check-torch-mlir-python
like instructed gives the errorOne option is of course to change the docs, but the underscore seems inconsistent with the other targets, i.e.
cmake --build build --target check-torch-mlir
works just fine.Another note is that in
projects/pt1/python/test/CMakeLists.txt
, there actually is this target defined with the hyphen:So it seems that somehow it is being overriden - making the one line change like I do here in the project name parameter seems to resolve this. But I'm not sure if that's the best solution. Looking for a review and some feedback here on the right approach to fix this.