Skip to content

Conversation

raayandhar
Copy link

When looking through development.md, running cmake --build build --target check-torch-mlir-python like instructed gives the error

ninja: error: unknown target 'check-torch-mlir-python', did you mean 'check-torch_mlir-python'?

One option is of course to change the docs, but the underscore seems inconsistent with the other targets, i.e. cmake --build build --target check-torch-mlir works just fine.
Another note is that in projects/pt1/python/test/CMakeLists.txt, there actually is this target defined with the hyphen:

add_lit_testsuite(check-torch-mlir-python "Running the torch-mlir Python regression tests"
  ${CMAKE_CURRENT_BINARY_DIR}
  DEPENDS ${TEST_DEPENDS}
  )
set_target_properties(check-torch-mlir-python PROPERTIES FOLDER "Tests")

So it seems that somehow it is being overriden - making the one line change like I do here in the project name parameter seems to resolve this. But I'm not sure if that's the best solution. Looking for a review and some feedback here on the right approach to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant