Skip to content

Fix image conversion state handling across formats #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix image conversion state handling across formats #3718

wants to merge 1 commit into from
+10 −8

Conversation

emmanuel-ferdman
Copy link

Why are these changes needed?

This PR fixes critical issues in image format conversion:

  • Undefined image variable - Ensured proper initialization for URL/local/bytes formats
  • Method argument mismatch - Removed unexpected parameter from convert_image_to_base64()
  • Null buffer references - Standardized BytesIO initialization across all formats
  • Missing format validation - Added explicit error for unsupported image types

Related issue number (if applicable)

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

@fuckgitb
Copy link

fuckgitb commented May 10, 2025 via email

@emmanuel-ferdman
Copy link
Author

@infwinston @CodingWithTim could you please take a look into this small PR when you get the chance? thanks 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuel-ferdman @fuckgitb