-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change to aes-cbc encryption #22
base: main
Are you sure you want to change the base?
Conversation
Memory usage change @ b7569ca
Click for full report table
Click for full report CSV
|
Memory usage change @ 6b790de
Click for full report table
Click for full report CSV
|
Memory usage change @ 23b7f88
Click for full report table
Click for full report CSV
|
Memory usage change @ fd6393d
Click for full report table
Click for full report CSV
|
Memory usage change @ eeac8f0
Click for full report table
Click for full report CSV
|
Memory usage change @ 52fbbe5
Click for full report table
Click for full report CSV
|
Memory usage change @ cbcfb9b
Click for full report table
Click for full report CSV
|
Memory usage change @ 5e3a4dd
Click for full report table
Click for full report CSV
|
@@ -161,18 +160,23 @@ void readFiles() | |||
if (lnurlATM != "null" || lnurlATM != "") | |||
{ | |||
baseURLATM = getValue(lnurlATM, ',', 0); | |||
// remove /api/v1.... and add /atm?lightning= | |||
int apiPos = baseURLATM.indexOf("api"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this replace required? why isn't the URL correct form the start?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its the correct url from the start for the lnurl endpont /fossa/api/v1/lnurl/
but for the atm page we need the public page /fossa/atm
page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Memory usage change @ 5fb35a7
Click for full report table
Click for full report CSV
|
lnbits/lnpos_extension#5