Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change to aes-cbc encryption #22

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: change to aes-cbc encryption #22

wants to merge 10 commits into from

Conversation

dni
Copy link
Member

@dni dni commented Feb 25, 2025

Copy link

Memory usage change @ b7569ca

Board flash % RAM for global variables %
esp32:esp32:esp32 💚 -528 - -528 -0.03 - -0.03 💚 -56 - -56 -0.02 - -0.02
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 -528 -0.03 -56 -0.02
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,-528,-0.03,-56,-0.02

Copy link

Memory usage change @ 6b790de

Board flash % RAM for global variables %
esp32:esp32:esp32 💚 -528 - -528 -0.03 - -0.03 💚 -56 - -56 -0.02 - -0.02
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 -528 -0.03 -56 -0.02
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,-528,-0.03,-56,-0.02

Copy link

Memory usage change @ 23b7f88

Board flash % RAM for global variables %
esp32:esp32:esp32 💚 -596 - -596 -0.03 - -0.03 💚 -56 - -56 -0.02 - -0.02
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 -596 -0.03 -56 -0.02
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,-596,-0.03,-56,-0.02

Copy link

Memory usage change @ fd6393d

Board flash % RAM for global variables %
esp32:esp32:esp32 💚 -596 - -596 -0.03 - -0.03 💚 -56 - -56 -0.02 - -0.02
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 -596 -0.03 -56 -0.02
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,-596,-0.03,-56,-0.02

Copy link

Memory usage change @ eeac8f0

Board flash % RAM for global variables %
esp32:esp32:esp32 🔺 +64 - +64 0.0 - 0.0 💚 -48 - -48 -0.01 - -0.01
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 64 0.0 -48 -0.01
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,64,0.0,-48,-0.01

Copy link

Memory usage change @ 52fbbe5

Board flash % RAM for global variables %
esp32:esp32:esp32 🔺 +64 - +64 0.0 - 0.0 💚 -48 - -48 -0.01 - -0.01
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 64 0.0 -48 -0.01
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,64,0.0,-48,-0.01

Copy link

Memory usage change @ cbcfb9b

Board flash % RAM for global variables %
esp32:esp32:esp32 🔺 +380 - +380 +0.02 - +0.02 💚 -48 - -48 -0.01 - -0.01
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 380 0.02 -48 -0.01
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,380,0.02,-48,-0.01

Copy link

Memory usage change @ 5e3a4dd

Board flash % RAM for global variables %
esp32:esp32:esp32 🔺 +296 - +296 +0.02 - +0.02 💚 -48 - -48 -0.01 - -0.01
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 296 0.02 -48 -0.01
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,296,0.02,-48,-0.01

@@ -161,18 +160,23 @@ void readFiles()
if (lnurlATM != "null" || lnurlATM != "")
{
baseURLATM = getValue(lnurlATM, ',', 0);
// remove /api/v1.... and add /atm?lightning=
int apiPos = baseURLATM.indexOf("api");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this replace required? why isn't the URL correct form the start?

Copy link
Member Author

@dni dni Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its the correct url from the start for the lnurl endpont /fossa/api/v1/lnurl/ but for the atm page we need the public page /fossa/atm page

Copy link
Collaborator

@motorina0 motorina0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Memory usage change @ 5fb35a7

Board flash % RAM for global variables %
esp32:esp32:esp32 🔺 +296 - +296 +0.02 - +0.02 💚 -48 - -48 -0.01 - -0.01
Click for full report table
Board lnpos
flash
% lnpos
RAM for global variables
%
esp32:esp32:esp32 296 0.02 -48 -0.01
Click for full report CSV
Board,lnpos<br>flash,%,lnpos<br>RAM for global variables,%
esp32:esp32:esp32,296,0.02,-48,-0.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants