-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] update to pydantic2 #21
base: main
Are you sure you want to change the base?
Conversation
this request a new major version and i will release 1.0.0 if this PR works
I think this
|
sorry its still a draft :D is going to be a pretty substantial change |
Ahh thanks, yeah I thought it would be a bit more intense. I've been fortunate, none of my other API projects have had any issues switching so far. |
Looked at migration of class LightningNodeUri here The only way I could make it work is to inject a 'lightning://' to make it a valid URL. The tests needed a change which hints at incompatibity going forward. The proper fix would involve changing the rust validation engine. I hope this helps somehow. |
this request a new major version and i will release 1.0.0 if this PR works
closes #18