-
Notifications
You must be signed in to change notification settings - Fork 2
Release preparations for v9.5.0 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace Gist-based badge system with BadgeSmith REST API - Implement HMAC-SHA256 authentication for secure badge updates - Add branch-specific badge support (master and feature branches) - Update CI/CD workflow to post test results via authenticated API - Refactor update-test-badge action to extract owner/repo/branch from context - Update README badges to use new BadgeSmith endpoints - Add Windows and macOS test badges to README - Remove Release Candidate status and warnings - Add comprehensive v9.5.0 CHANGELOG entry - Document SQS Event Source bug fix (#6, #9) - Document eager service loading feature (#7, #8) - Update LocalStack container to 4.9.1 - Update Aspire.Hosting to 9.5.0 - Credit contributors: @slang25 (eager loading), @Blind-Striker (bug fixes, infra)
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the repository for the v9.5.0 stable release and migrates the badge system from GitHub Gist to the new BadgeSmith REST API with HMAC-SHA256 authentication.
- Updated LocalStack container version from 4.6.0 to 4.9.1
- Migrated badge system from Gist-based storage to BadgeSmith API with HMAC authentication
- Added comprehensive CHANGELOG entry documenting v9.5.0 features and fixes
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.LocalStack/Container/LocalStackContainerImageTags.cs | Updates LocalStack container image tag to version 4.9.1 |
| playground/lambda/.../Properties/launchSettings.json | Converts Unix-style paths to Windows-style paths for Lambda tooling |
| README.md | Updates badge URLs to use new BadgeSmith API format and removes RC warning |
| CHANGELOG.md | Adds comprehensive v9.5.0 release notes with features, fixes, and breaking changes |
| .github/workflows/ci-cd.yml | Refactors workflow to use BadgeSmith API instead of Gist-based badge storage |
| .github/actions/update-test-badge/action.yml | Complete rewrite to support BadgeSmith API with HMAC authentication |
| .github/actions/update-test-badge/README.md | Updates documentation for new BadgeSmith API integration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: Update test badge via BadgeSmith API | ||
| if: always() && github.event_name == 'push' && github.ref == 'refs/heads/master' | ||
| continue-on-error: true | ||
| uses: ./.github/workflows/update-test-badge |
Copilot
AI
Oct 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action path is incorrect. It should reference the action directory ./.github/actions/update-test-badge, not ./.github/workflows/update-test-badge.
| uses: ./.github/workflows/update-test-badge | |
| uses: ./.github/actions/update-test-badge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 18
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| - name: Update test badge via BadgeSmith API | ||
| if: always() && github.event_name == 'push' && github.ref == 'refs/heads/master' | ||
| continue-on-error: true | ||
| uses: ./.github/workflows/update-test-badge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: CI/CD Workflow Action Path Error
The Update test badge step in the CI/CD workflow incorrectly references the custom action. It points to ./.github/workflows/update-test-badge instead of ./.github/actions/update-test-badge, which is where the action is located. This path mismatch means the action won't be found, causing the step to fail.
| "commandLineArgs": "exec --depsfile ./LocalStack.Lambda.UrlShortener.deps.json --runtimeconfig ./LocalStack.Lambda.UrlShortener.runtimeconfig.json $(HOME)/.dotnet/tools/.store/amazon.lambda.testtool/0.11.0/amazon.lambda.testtool/0.11.0/content/Amazon.Lambda.RuntimeSupport/net8.0/Amazon.Lambda.RuntimeSupport.dll LocalStack.Lambda.UrlShortener::LocalStack.Lambda.UrlShortener.Function::FunctionHandler", | ||
| "workingDirectory": "./bin/$(Configuration)/net8.0" | ||
| "commandLineArgs": "exec --depsfile ./LocalStack.Lambda.UrlShortener.deps.json --runtimeconfig ./LocalStack.Lambda.UrlShortener.runtimeconfig.json %USERPROFILE%\\.dotnet\\tools\\.store\\amazon.lambda.testtool\\0.11.0\\amazon.lambda.testtool\\0.11.0\\content\\Amazon.Lambda.RuntimeSupport\\net8.0\\Amazon.Lambda.RuntimeSupport.dll LocalStack.Lambda.UrlShortener::LocalStack.Lambda.UrlShortener.Function::FunctionHandler", | ||
| "workingDirectory": ".\\bin\\$(Configuration)\\net8.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Cross-Platform Path Issue in Lambda Projects
The launchSettings.json files for the Lambda projects were updated to use Windows-specific paths and environment variables (%USERPROFILE%, backslashes) instead of cross-platform Unix-style paths ($(HOME), forward slashes). This breaks cross-platform compatibility, preventing these projects from launching on Linux/macOS systems.
This PR prepares the repository for the v9.5.0 stable release and migrates the badge system from GitHub Gist to the new BadgeSmith REST API with HMAC-SHA256 authentication.
Key Changes:
Documentation Updates
BadgeSmith API Migration
/badges/tests/{platform}/{owner}/{repo}/{branch}CI/CD Workflow Updates
update-test-badgeaction to use BadgeSmith APITESTDATASECRETRelated Issue(s):
🔄 Type of Change
🎯 Aspire Compatibility
🧪 Testing
How has this been tested?
Badge System Testing:
Feature Testing:
4.9.1Test Environment:
📚 Documentation
.github/actions/update-test-badge/README.md)✅ Code Quality Checklist
Migration Path:
TESTDATASECRETrepository secret with HMAC keyGIST_SECRETrepository secret (no longer needed)BADGE_GIST_IDenvironment variable (removed from workflow)Impact:
Performance Impact:
Positive:
Neutral:
By submitting this pull request, I confirm that:
TESTDATASECRET) are in placeapi.localstackfor.net